Closed Bug 1972746 Opened 6 months ago Closed 6 months ago

[wpt-sync] Sync PR 53244 - Reland "Remove block_until_head_timeout_eager_prefetch test override"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox142 fixed)

Status:
RESOLVED FIXED
Milestone:
142 Branch
Tracking Flags:
Tracking Status
firefox142 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53244 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53244
Details from upstream follow.

Domenic Denicola <domenic@chromium.org> wrote:

Reland "Remove block_until_head_timeout_eager_prefetch test override"

This reverts commit 8780e7690e82bc6cb6bf73ff6a7d85fdfa3b341a.

Reason for revert: there is no evidence in ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29 that any of the tests touched here were failing. The only possible candidate is virtual/prefetch/external/wpt/speculation-rules/prefetch/initiators-a-element.sub.https.html?cross-site, but that test should not be affected by block_until_head_timeout_eager_prefetch.

Given how many other tests failed in the run at https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/126765/overview, and how we had similar random failures in https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20(dbg)(1)/126771/overview after this revert, it seems more likely that this was an infra issue.

Bug: 356622798
Original change's description:

Revert "Remove block_until_head_timeout_eager_prefetch test override"

This reverts commit 03716983faf5d10624e0af646dc2e7503cdb18b7.

Reason for revert: Suspected to cause fails on ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29

Bug: 356622798
Original change's description:

Remove block_until_head_timeout_eager_prefetch test override

Web platform tests should, in general, run under the same configuration
we ship to our users, or at least the same as experimental web platform
features. This is the first step in removing some of the overrides we
are currently using.

This required updating two web platform tests which were written to
assume an infinite block-until-head timeout, and thus did not pass on
stable Chromium as shipped to users and shown on https://wpt.fyi/.

Eventually, it might be good to remove these block_until_head_timeout
parameters, at least for speculation rules.

Bug: 356622798
Change-Id: If4b00cfbfbe5d6c7cf2dd55a3428a129e40868f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6636809
Reviewed-by: Kent Tamura \<tkent@chromium.org>
Reviewed-by: Hiroshige Hayashizaki \<hiroshige@chromium.org>
Commit-Queue: Domenic Denicola \<domenic@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1474799}

Bug: 356622798
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I50ee9efb9f2b9972dd43cfa282b46317dd275d4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6650667
Owners-Override: Alexandra Reimers \<areimers@chromium.org>
Auto-Submit: Alexandra Reimers \<areimers@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alexandra Reimers \<areimers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1474891}

Bug: 356622798
Change-Id: I62821f6dfe4de78c8c221c858871eda9607d6be8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6651241
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Kent Tamura \<tkent@chromium.org>
Auto-Submit: Domenic Denicola \<domenic@chromium.org>
Commit-Queue: Kent Tamura \<tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1475381}

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests and 2 subtests

Status Summary

Firefox

ERROR: 13

Chrome

OK : 13
PASS : 16
FAIL : 6

Safari

ERROR: 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests and 2 subtests

Status Summary

Firefox

ERROR: 13

Chrome

OK : 13
PASS : 16
FAIL : 6

Safari

ERROR: 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests and 2 subtests

Status Summary

Firefox

ERROR: 13

Chrome

OK : 13
PASS : 16
FAIL : 6

Safari

ERROR: 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests and 2 subtests

Status Summary

Firefox

ERROR: 13

Chrome

OK : 13
PASS : 16
FAIL : 6

Safari

ERROR: 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f08a7c6f4cd2 https://hg.mozilla.org/integration/autoland/rev/cbefca5882ff [wpt PR 53244] - Reland "Remove block_until_head_timeout_eager_prefetch test override", a=testonly

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 13 tests and 2 subtests

Status Summary

Firefox

ERROR: 13

Chrome

OK : 13
PASS : 16
FAIL : 6

Safari

ERROR: 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/cbefca5882ff

Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox142: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
You need to log in before you can comment on or make changes to this bug.