1972762 - Make `HTMLEditor` stop scanning visible character in `nsTextFragment` with calling `CharAt`

Status: RESOLVED FIXED

(Core :: DOM: Editor, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

A patch for bug 1951039 will introduce new "find" methods of visible first/last character in nsTextFragment. It's faster than for loops which use nsTextFragment::GetCharAt(). So, HTMLEditor should use the new APIs instead.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1972762 - part 1: Make `HTMLEditUtils::LineRequiresPaddingLineBreakToBeVisible` stop using `nsTextFragment::CharAt` r=m_kato!

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1972762 - part 2: Make `HTMLEditUtils::IsVisiblePreformattedNewLine` stop using `nsTextFragment::CharAt` r=m_kato!

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1972762 - part 3: Make `HTMLEditUtils::GetPreviousNonCollapsibleCharOffset` stop using `nsTextFragment::CharAt` r=m_kato!

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1972762 - part 4: Make `HTMLEditUtils::GetInclusiveNextNonCollapsibleCharOffset` stop using `nsTextFragment::CharAt` r=m_kato!

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1972762 - part 5: Make `HTMLEditUtils::GetPreviousPreformattedNewLineInTextNode` stop using `nsTextFragment::CharAt` r=m_kato!,jjaschke!,#dom-core

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1972762 - part 6: Make `HTMLEditUtils::GetInclusiveNextPreformattedNewLineInTextNode` stop using `nsTextFragment::CharAt` r=m_kato!

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1972762 - part 7: Make `WhiteSpaceVisibilityKeeper::NormalizeVisibleWhiteSpacesWithoutDeletingInvisibleWhiteSpaces` stop using `nsTextFragment::CharAt` within the loops r=m_kato!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/480cd5408a0d
https://hg.mozilla.org/integration/autoland/rev/a8fdd4e7a1ac
part 1: Make `HTMLEditUtils::LineRequiresPaddingLineBreakToBeVisible` stop using `nsTextFragment::CharAt` r=m_kato

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a27f4d4df85c
https://hg.mozilla.org/integration/autoland/rev/4db2b9760516
part 2: Make `HTMLEditUtils::IsVisiblePreformattedNewLine` stop using `nsTextFragment::CharAt` r=m_kato

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bd0ba1eeb32b
https://hg.mozilla.org/integration/autoland/rev/dd375f98887e
part 3: Make `HTMLEditUtils::GetPreviousNonCollapsibleCharOffset` stop using `nsTextFragment::CharAt` r=m_kato

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d0166b8c8561
https://hg.mozilla.org/integration/autoland/rev/7222ac2e728c
part 4: Make `HTMLEditUtils::GetInclusiveNextNonCollapsibleCharOffset` stop using `nsTextFragment::CharAt` r=m_kato

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c73c3f394b1a
https://hg.mozilla.org/integration/autoland/rev/324d5e54cf33
part 5: Make `HTMLEditUtils::GetPreviousPreformattedNewLineInTextNode` stop using `nsTextFragment::CharAt` r=m_kato,jjaschke,dom-core

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/40052dc92207
https://hg.mozilla.org/integration/autoland/rev/292100fbcdc7
part 6: Make `HTMLEditUtils::GetInclusiveNextPreformattedNewLineInTextNode` stop using `nsTextFragment::CharAt` r=m_kato

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e9f918fac012
https://hg.mozilla.org/integration/autoland/rev/6b2f8ee67c66
part 7: Make `WhiteSpaceVisibilityKeeper::NormalizeVisibleWhiteSpacesWithoutDeletingInvisibleWhiteSpaces` stop using `nsTextFragment::CharAt` within the loops r=m_kato

Comment 15

[amarc]

https://hg.mozilla.org/mozilla-central/rev/a8fdd4e7a1ac
https://hg.mozilla.org/mozilla-central/rev/4db2b9760516
https://hg.mozilla.org/mozilla-central/rev/dd375f98887e
https://hg.mozilla.org/mozilla-central/rev/7222ac2e728c

Comment 16

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/324d5e54cf33
https://hg.mozilla.org/mozilla-central/rev/292100fbcdc7
https://hg.mozilla.org/mozilla-central/rev/6b2f8ee67c66