1972857 - Failure to send signed email from mailto: link when main Thunderbird window is not open — personal key not loaded

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Chris Zim]

Steps to reproduce:

Ensure Thunderbird is fully closed.
Click a mailto: link (e.g. in a browser).
Compose a message (digitally signed by default).
Attempt to send it.

Actual results:

When sending a digitally signed message initiated from a mailto: link (e.g. from a web browser or external app), Thunderbird fails to send the message if the main application window is not already open. It shows the following alert:
"Unable to send the message, because there is a problem with your personal key."
This does not occur when composing messages via the standard workflow: opening the main Thunderbird window first and then composing a message.

More than happy to provide additional info - just let me know.

Expected results:

Message should be signed and sent successfully.

Comment 1

[Magnus Melin [:mkmelin]]

Thunderbird always open the main window (nowadays) first, also when opening from mailto link. So how do you get to that situation?

Comment 2

[Chris Zim]

Simple. As outlined above, a single mail composition window opens (no main window) once I click on a mailto: hyperlink. Platform is OSX 15.5 if that makes a difference.

Comment 3

[Magnus Melin [:mkmelin]]

Maybe it's set up to use a bit more exotic command...

I notice these https://searchfox.org/comm-central/rev/2adc274b7011154d6f0675b7ff628f29b1547eb4/mail/components/MessengerContentHandler.sys.mjs#290,295,705 should probably be getOrOpen3PaneWindow().then(openURI(xuri));

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: Bug 1972857 - Make sure all cases of opening compose first open a 3pane window. r=#thunderbird-reviewers

We had missed handling the anchient -remote commands (Firefox removed them in bug 1080319)

I don't think openurl ever did something useful in Thunderbird.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/58a9641482eb
Make sure all cases of opening compose first open a 3pane window. r=edicharry

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9499762 [details]
Bug 1972857 - Make sure all cases of opening compose first open a 3pane window. r=#thunderbird-reviewers

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Broken functionality in certain scenarios
• User impact if declined: Broken functionality, confusion why it's not working.
• Is this code covered by automated tests?: No
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: Yes
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Confined change
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: none

Comment 7

[Corey Bryant]

Magnus, this seems to be a corner case that doesn't really fall under uplift critera for ESR (https://developer.thunderbird.net/releases/uplifting-fixes#uplifts-to-release-and-esr). Are there a lot of reports for this issue? I noticed the reporter is not on ESR and this is already fixed in Release.

Comment 8

[Magnus Melin [:mkmelin]]

Up to you. Strictly not only an openpgp issue. Add-ons have the same problem, with subtle breakage.

Comment 9

[Corey Bryant]

Comment on attachment 9499762 [details]
Bug 1972857 - Make sure all cases of opening compose first open a 3pane window. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr140
Picking this up as it's a fairly limited release and it has baked for a while.

Comment 10

[Stephen King (:sking)]

Thunderbird 140.5.0esr:
https://hg-edge.mozilla.org/releases/comm-esr140/rev/71145ad31728cb4a609a9a5a5b940c660a9dac6b