1972921 - WebGPU does not display textures rendered by a compute pass

Status: RESOLVED FIXED

(Core :: Graphics: WebGPU, defect, P2)

Description

[Andy Leiserson [:aleiserson]]

If the WebGPU canvas texture is written by a compute pass instead of a render pass, the contents are not displayed.

This problem can be seen at:

• https://webgpu.github.io/webgpu-samples/?sample=cornell (bug 1972628)
• https://webgpufundamentals.org/webgpu/resources/editor.html?url=/webgpu/webgpu-storage-texture-canvas.html (bug 1962747)

The problem goes away if something like the following is added at the end of command encoding:

    commandEncoder.beginRenderPass({
        colorAttachments: [
        {
          view: this.outputView,
          clearValue: [1, 0.2, 0.3, 1],
          loadOp: 'load',
          storeOp: 'store',
        },
        ]
    }).end();

It seems suspect to me that we do not call TrackPresentationContext for textures bound to a compute pass.

Comment 1

[Jim Blandy :jimb]

It seems suspect to me that we do not call TrackPresentationContext for textures bound to a compute pass.

I'm pretty sure this is the correct.

Comment 2

[Andy Leiserson [:aleiserson]]

Linking some references I found related to support for writing to storage textures in fragment shaders. Seems like it is supported, but perhaps not consistently.

https://github.com/gpuweb/gpuweb/issues/4696
https://github.com/gpuweb/gpuweb/issues/3838
https://github.com/gpuweb/gpuweb/pull/4326
https://github.com/gpuweb/gpuweb/issues/513

Comment 3

[Andy Leiserson [:aleiserson]]

Attachment: Bug 1972921 - Track canvas textures used in bind groups

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f1ebe8385b54
https://hg.mozilla.org/integration/autoland/rev/feefbda904cb
Track canvas textures used in bind groups r=webgpu-reviewers,nical

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5fa41eb1d330
https://hg.mozilla.org/integration/autoland/rev/2a978a01da7a
Revert "Bug 1972921 - Track canvas textures used in bind groups r=webgpu-reviewers,nical" for causing reftests failures.

Comment 6

[Serban Stanca [:SerbanS]]

Reverted this because it was causing reftests failures.

• Revert link
• Push with failures
• Failure Log
• Failure line: REFTEST TEST-UNEXPECTED-FAIL | dom/webgpu/tests/reftest/draw.html == dom/webgpu/tests/reftest/draw-ref.html | load failed: timed out waiting for reftest-wait to be removed

Comment 7

[Andy Leiserson [:aleiserson]]

I am going to land this with the reftests disabled for now. Filed bug 1975273 to resolve the reftest issues.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b8dc666d504f
https://hg.mozilla.org/integration/autoland/rev/7b2911e61cd3
Track canvas textures used in bind groups r=webgpu-reviewers,nical

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/7b2911e61cd3

Comment 10

[Andy Leiserson [:aleiserson]]

Attachment: Bug 1972921 - Track canvas textures used in bind groups

Original Revision: https://phabricator.services.mozilla.com/D255033

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Some WebGPU applications will not work
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Visit URLs below; compare to Chrome
• Risk associated with taking this patch: Low
• Explanation of risk level: No risk to non-WebGPU sites or WebGPU sites not rendering to canvas textures. Very small risk of performance regression if a site is doing something pathological re: canvas texture rendering, and it is very unlikely such a site will do anything useful without this fix.
• String changes made/needed: No
• Is Android affected?: no

Comment 12

[Andy Leiserson [:aleiserson]]

Ack, there's a typo in my uplift request. "WebGPU sites not rendering to canvas textures" should be "WebGPU sites not rendering to canvas textures via a bind group". Rendering to a canvas texture is most things that render, but the rendering is via a render attachment and not a bind group. Rendering via a bind group is uncommon.

Comment 13

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Some WebGPU applications will not work
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Visit URLs below; compare to Chrome
• Risk associated with taking this patch: Low
• Explanation of risk level: No risk to non-WebGPU sites or WebGPU sites not rendering to canvas textures via a bind group (i.e., most WebGPU sites). Very small risk of performance regression if a site is doing something pathological re: rendering to a canvas texture via a bind group, and it is very unlikely such a site will do anything useful without this fix.
• String changes made/needed: No
• Is Android affected?: no

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/97daff9f06ff
https://hg.mozilla.org/releases/mozilla-beta/rev/633beea666c0