1972979 - [wpt-sync] Sync PR 53268 - Don't clear the layout/style flags on moveBefore

Status: NEW

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53268 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53268
Details from upstream follow.

zhoupeng <[e-mail]> wrote:

Don't clear the layout/style flags on moveBefore

During moveBefore, Element::RemovedFrom does not reset
ComputedStyle to nullptr while Node::RemovedFrom clears the
layout/style flags. We intentionally preserve the flags so that the
layout is recomputed and reattached on the next style recalc. See
https://github.com/facebook/react/issues/33187 for more details.

Bug: 417426569
Change-Id: Idef745ab48d064a8d836f2785010e1d813acf5e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6646885
Reviewed-by: Mason Freed \<[e-mail]>
Reviewed-by: Noam Rosenthal \<[e-mail]>
Commit-Queue: Peng Zhou \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1476013}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=70ad6788df3613699c8cf395aeefc5cfe1d32ceb

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /dom/nodes/moveBefore/child-style-preserve.html [wpt.fyi]
  • child-style-preserve: FAIL (Chrome: FAIL, Safari: FAIL)