1972995 - Improve naming of webrtc runnables

Status: RESOLVED FIXED

(Core :: WebRTC, task, P3)

Description

[Andreas Pehrson [:pehrsons]]

The Runnable class implements nsINamed in Nightly to improve tracing through the profiler. The name of webrtc runnables has until now been "TaskQueueWrapper::CreateTaskRunner" which is not very helpful.

The libwebrtc TaskQueueBase::PostTask interface however includes a Location arg that could include info on the callsite a la std::source_location. That class isn't fleshed out in libwebrtc but is overriden in Chromium. We could do something similar.

Note std::source_location is c++20, but one can achieve the same with __builtin_FUNCTION et al on supported toolchains.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1972995 - Tag webrtc invocables with location when wrapping them as runnables. r?bwc!,mjf!

This does mainly two things:

• Overrides webrtc::Location with a new class declaration in libwebrtcglue,
  that makes use of __builtin_FUNCTION et al. on supported toolchains.
• Uses the new location info to construct a better name (through nsINamed) to
  tag invocable-wrapped runnables with, for visibility in the profiler.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/85a84ec9aee3
https://hg.mozilla.org/integration/autoland/rev/21b860b62cd4
Tag webrtc invocables with location when wrapping them as runnables. r=bwc,mjf

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/21b860b62cd4