Open Bug 1973009 Opened 19 hours ago

[wpt-sync] Sync PR 53271 - WPT: fix overuse of PREFETCH_PROXY_BYPASS_HOST

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(Not tracked)

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53271 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53271
Details from upstream follow.

Domenic Denicola <domenic@chromium.org> wrote:

WPT: fix overuse of PREFETCH_PROXY_BYPASS_HOST

Several tests had copied usage of PREFETCH_PROXY_BYPASS_HOST when it was
not necessary, and instead they could work with any cross-origin or
cross-site host. Move them to using get_host_info().NOTSAMESITE_HOST
instead for this purpose. (This host had to be exposed by editing
get-host-info.sub.js.)

Rename PREFETCH_PROXY_BYPASS_HOST to
CROSS_ORIGIN_HOST_THAT_WORKS_WITH_ACIWCO ("ACIWCO" =
"anonymous-client-ip-when-cross-origin"), and add a comment about
exactly when it is to be used, plus a TODO about making this a more
official part of the web platform tests infrastructure in the future.

Notable specific test cases:

  • anonymous-client.https.html was actually testing the ACIWCO feature, so it uses CROSS_ORIGIN_HOST_THAT_WORKS_WITH_ACIWCO legitimately.

  • cross-origin-cookies.https.html was testing two things: cross-origin cookies, and the fact that if two prefetches were sent, the first with ACIWCO and the second without, then ACIWCO would apply. Split it into two tests, so that one test can focus only on cookies and the other can test the ACIWCO interaction.

  • user-pass.https.html was using ACIWCO for no reason related to the test. Stop doing so.

We thus end up with only two test files, anonymous-client.https.html and
cross-origin-cookies-anonymous-client-ip-duplicate.https.html, which
depend on ACIWCO. Future work will move these into a specific virtual
test suite.

Bug: 409806816
Change-Id: Ia7de51862e0b99ddc13bfcf71ecf4d04a2f89b02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6650746
Auto-Submit: Domenic Denicola \<domenic@chromium.org>
Commit-Queue: Hiroki Nakagawa \<nhiroki@chromium.org>
Reviewed-by: Hiroki Nakagawa \<nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1476054}

You need to log in before you can comment on or make changes to this bug.