1973122 - [wpt-sync] Sync PR 53281 - Revert "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53281 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53281
Details from upstream follow.

Scott Haseley <[e-mail]> wrote:

Revert "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries"

This reverts commit ae18e2a905e16727ae7c4e55988095c085cd09aa.

Reason for revert: Flaky on Linux bots due to race condition between rAF and presentation time callbacks. https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Aheadless_shell_wpt%2Fexternal%2Fwpt%2Fsoft-navigation-heuristics%2Flcp%2Ftentative%2Fraf-loop.html

Original change's description:

[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries

This tests that a click handler invocation which leads to the detection
of a soft navigation may defer some work with requestAnimationFrame, and
that work can generate additional soft LCP performance entries.

Change-Id: Ic432a8fed21a2836c122e6c1d7ba38150c901753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6651298
Commit-Queue: Johannes Henkel \<[e-mail]>
Reviewed-by: Annie Sullivan \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1475225}

Change-Id: I866e47960f614817a26d14476098dbfe44021ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6657418
Bot-Commit: Rubber Stamper \<[e-mail]>
Reviewed-by: Michal Mocny \<[e-mail]>
Commit-Queue: Scott Haseley \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1476288}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 53281 applied with additional changes from upstream: 95391fe4b2d50ea8fb115882728b20fd128c1ac3

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=9d1bd18bab54cdb2abd0f688718365fa28739633

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7737e0e2c278
https://hg.mozilla.org/integration/autoland/rev/98d725c31974
[wpt PR 53281] - Revert "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries", a=testonly

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/98d725c31974