1973142 - Save to PDF shows dialog to save a zero byte file

Status: VERIFIED FIXED

(Firefox for Android :: Downloads, defect)

Description

[Jonathan Almeida [:jonalmeida]]

Attachment: Screenshot 2025-06-19 at 8.35.03 PM.png

Steps to reproduce

1. Navigate to duck.com
2. Open the menu and choose 'Save to PDF' (or via the share icon).
3. Observe the dialog.

Expected behaviour

• The dialog should have no mention of file size if it's not possible to determine it.

Actual behaviour

• The dialog shows a size of 0 bytes instead. See screenshot.

Device information

• Firefox version: 141.0a1-20250616214059
• Android device model: Pixel 8a
• Android OS version: Android 16

Any additional information?

n/a

Comment 1

[Nicholas Poon [:Nick]]

This is likely a regression from Bug 1962682, when we switched from a bottom sheet to an alert dialog. I also attached a screenshot of how the original bottom sheet displayed this kind of scenario - the file size is not shown as mentioned in the expected behaviour.

Comment 2

[Nicholas Poon [:Nick]]

Attachment: Screenshot_20250620_104954.png

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

:giorga, since you are the author of the regressor, bug 1962682, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Iorga Gabriel]

Attachment: Bug 1973142 - Save dialog should have no mention of file size if it's not possible to determine it.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7e8e43182965
https://hg.mozilla.org/integration/autoland/rev/fb49e4eae195
Save dialog should have no mention of file size if it's not possible to determine it. r=android-reviewers,npoon,android-l10n-reviewers,delphine

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fb49e4eae195

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1962682

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:giorga, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox141 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Adina Petridean QA [:apetridean]]

Attachment: Screenrecorder-2025-07-07-17-19-04-540.mp4

Verified as fixed on the latest Nightly 142.0a1 from 5.07.2025 with Poco M4 Pro (Android 12).