1973157 - Mac native buttons smaller and not centered after bug 1971369

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Sam Johnson]

Attachment: buttons.png

After bug 1971369 (per mozregression), Mac native styled buttons appear to be smaller, with text no longer centered vertically or horizontally. Attached screenshot illustrating the regression (top is pre-regression, bottom is post-regression).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1971369

:emilio, since you are the author of the regressor, bug 1971369, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1973157 - Fix cocoa native rendering regression from bug 1971369. r=#mac-reviewers!

D253206 changed the margins to use an IntMargin. However I didn't
realize the order was subtly different. The cocoa code was using left,
top, right, bottom, while IntMargin uses the CSS order (top, right,
bottom, left). So fix the order of the numbers to preserve previous
behavior.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1973157 - Use NSRect consistently in nsNativeThemeCocoa. r=#mac-reviewers

Wrote while debugging. They're typedefs so this is just less confusing.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f6b73c87ee01
https://hg.mozilla.org/integration/autoland/rev/de60bae5ab9b
Fix cocoa native rendering regression from bug 1971369. r=mac-reviewers,spohl
https://github.com/mozilla-firefox/firefox/commit/40e647a7f08a
https://hg.mozilla.org/integration/autoland/rev/36c907b1d8b7
Use NSRect consistently in nsNativeThemeCocoa. r=mac-reviewers,spohl

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/de60bae5ab9b
https://hg.mozilla.org/mozilla-central/rev/36c907b1d8b7