197317 - In builds without midas, document.designMode should be undefined

Status: RESOLVED WONTFIX

(Core :: DOM: Editor, defect, P3)

Description

[Jesse Ruderman]

Phoenix has document.designMode == "off".  This makes it difficult (impossible?)
to detect whether a given browser supports Midas without trying to create a
Midas iframe.  It would be nice if document.designMode were only defined in
browsers supporting Midas.

Comment 1

[Boris Zbarsky [:bzbarsky]]

I'm not sure this is actually possible, since you can't #ifdef IDL and there's
no way to make a string-returning function return "undefined" instead -- the
best it can do is return "null".

Comment 2

[Peter Van der Beken [:peterv]]

One way to solve that is like we did for XPathEvaluator with a separate
interface, a tearoff and a check in QI. Sounds like a bit much for such a small
annoyance. :-/

Comment 3

[Boris Zbarsky [:bzbarsky]]

Actually, if your designMode attr lives on a separate interface, there's no need
for a tearoff is there?  You just have to make sure to #ifdef out the classinfo,
QI line for that interface, and impl of designMode in builds without Midas.

Comment 4

[Peter Van der Beken [:peterv]]

If you don't want it to be pluggable, sure. And I do think we should move midas
to its own interface and have a tearoff anyway.

Comment 5

[Mike Kaply [:mkaply]]

Actually, Phoenix should have midas.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Doesn't Phoenix build with plaintext editor only?  In which case, why would it
have Midas?

Comment 7

[Mike Kaply [:mkaply]]

I meant "should" in a theoretical sense.

The goal here is a browser only scenario.

When yahoo, and hotmail, etc. switch to rich email editing, for instance, you
don't want phoenix to be the only browser that doesn't do it.

The infrastructure for making midas work is not big and should be a core part of
Mozilla.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Um... It involves pulling in the entire HTML editor, no?   That's not that small...

The point is, this does not apply to phoenix only.  As long as we have
--enable-plaintext-editor-only, all Midas functionality should be compiled out
when that flag is used (I've brought this up before.....)

Comment 9

[Peter Van der Beken [:peterv]]

I'm working on a solution for this and other "extension" interfaces for
documents. Brade: I hope you're ok with me taking this, let me know if not.

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to comment #9)
> I'm working on a solution for this and other "extension" interfaces for
> documents. Brade: I hope you're ok with me taking this, let me know if not.

This bug make camino with midas enabled not working because they browser sniff
in order to determine if midas is really suported or not. 
Peter have you progressed on that bug ?

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 12

[Mike Kaply [:mkaply]]

There should be no builds without midas.