1973218 - BrowserTestUtils.waitForLoad should skip about:blank by default

Status: RESOLVED FIXED

(Testing :: Mochitest, enhancement)

Description

[Vincent Hilla [:vhilla]]

After bug 543435, an initial navigation to about:blank will happen synchronously. During our work, that broke many tests that used BrowsingTestUtils.browserLoaded as it resolved unexpectedly for about:blank. As a follow-up / clean-up once bug 543435 landed, we could look into browserLoaded skipping about:blank unless explicitly passed to wantLoad.

Also see https://phabricator.services.mozilla.com/D155376#inline-1376767

Comment 1

[Vincent Hilla [:vhilla]]

Attachment: WIP: Bug 1973218 - Refactor: Convert browserLoaded to take an options object. r=#firefox-desktop-core-reviewers!

Comment 2

[Vincent Hilla [:vhilla]]

Attachment: Bug 1973218 - Have browserLoaded ignore about:blank by default. r=#firefox-desktop-core-reviewers!

This will be helpful for bug 543435.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2294bbd03299
https://hg.mozilla.org/integration/autoland/rev/eb0bb8cda0cb
Have browserLoaded ignore about:blank by default. r=firefox-desktop-core-reviewers ,mossop,webdriver-reviewers,extension-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,migration-reviewers,home-newtab-reviewers,urlbar-reviewers,dao,nsharpley,robwu,mconley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/850454f8ce82
https://hg.mozilla.org/integration/autoland/rev/3a3895fe70d8
Revert "Bug 1973218 - Have browserLoaded ignore about:blank by default. r=firefox-desktop-core-reviewers ,mossop,webdriver-reviewers,extension-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,migration-reviewers,home-newtab-reviewers,urlbar-reviewers,dao,nsharpley,robwu,mconley" for causing failures at browser_bug627234_perwindowpb.js.

Comment 5

[Atila Butkovits]

Backed out for causing failures at browser_bug627234_perwindowpb.js.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/3a3895fe70d890da681cdf0264853b1440586bee

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C24.04%2Copt%2Cmochitests%2Cwith%2Csoftware%2Cwebrender%2Cenabled%2Ctest-linux2404-64%2Fopt-mochitest-browser-chrome-swr%2Cbc2&revision=a147b03eede6d56be9d84e2fb2a55f342f966d3e&selectedTaskRun=daPgQFv-RX-jdaK54zGnQw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=520418326&repo=autoland&lineNumber=10672

Comment 6

[Vincent Hilla [:vhilla]]

Ah, I had the same issue with dom/tests/browser/browser_ConsoleStoragePBTest_perwindowpb.js.

The method whenNewWindowLoaded in browser_bug627234_perwindowpb.js waits for load on the browser window but that doesn't guarantee the browser is fully loaded. I'm not sure how exactly, but this startLoadingURIString testURI flakily gets overwritten by an initial content document that is either about:blank or about:privatebrowsing. An easy fix is to use BrowserTestUtils.openNewBrowserWindow({ private }) which waits for BrowserTestUtils:ContentEvent:load instead of load.

I pushed to try with --rebuild 3 and both opt, debug in case there are more flaky failures: https://treeherder.mozilla.org/jobs?repo=try&revision=9e1567f276a1a2df8e8bc399e6b3a4f2c4d91a38

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8867db2c958c
https://hg.mozilla.org/integration/autoland/rev/f7217a7cc2da
Have browserLoaded ignore about:blank by default. r=firefox-desktop-core-reviewers ,mossop,webdriver-reviewers,extension-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,migration-reviewers,home-newtab-reviewers,urlbar-reviewers,dao,nsharpley,robwu,mconley

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f7217a7cc2da