1973248 - [wpt-sync] Sync PR 53286 - Carry attr-tainting through if() style ranges

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53286 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53286
Details from upstream follow.

Munira Tursunova <[e-mail]> wrote:

Carry attr-tainting through if() style ranges

Bug: 408011559
Change-Id: I650cb8f84b4b3b5b7adee88668399ecde266e93a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6657162
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Commit-Queue: Munira Tursunova \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1476489}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=651820ad4061cb104425f89cc0a8aa0e3f83162b

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 43 subtests

Status Summary

Firefox

OK : 1
PASS: 22
FAIL: 21

Chrome

OK : 1
PASS: 38
FAIL: 5

Safari

OK : 1
PASS: 22
FAIL: 21

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-values/attr-security.html [wpt.fyi]
  • '--x: image-set(attr(data-foo))' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • '--x: src(attr(data-foo))' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • 'background-image: src("https://does-not-exist.test/404.png")' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: FAIL, Safari: FAIL)
  • '--x: src(string("https://does-not-exist.test" attr(data-foo)))' with data-foo="/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • 'background-image: src(string("https://does-not-exist.test/""404.png"))' with data-foo="/404.png": FAIL (Chrome: FAIL, Safari: FAIL)
  • '--x: attr(data-foo type(<url>))' with data-foo="url(https://does-not-exist.test/404.png)": FAIL (Chrome: FAIL, Safari: FAIL)
  • '--x: image(attr(data-foo))' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • 'background-image: image("https://does-not-exist.test/404.png")' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: FAIL, Safari: FAIL)
  • 'background-image: url(https://does-not-exist.test/404.png), attr(data-foo type(<image>))' with data-foo="linear-gradient(#000000, #ffffff)": FAIL (Chrome: PASS, Safari: FAIL)
  • '--x: image-set(var(--y, attr(data-foo)))' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • '--x: image-set(var(--some-string))' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • 'background-image: image-set(var(--some-string))' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • '--x: image-set(var(--some-string-list))' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • 'background-image: image-set(var(--some-string-list))' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • '--registered-color: attr(data-foo type(<color>))' with data-foo="blue": FAIL (Chrome: PASS, Safari: FAIL)
  • '--x: image-set(var(--some-other-url))' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • '--x: image-set(if(style(--true): attr(data-foo);))' with data-foo="https://does-not-exist.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • 'background-image: image-set(
    if(style(--true): url(https://does-not-exist-2.test/404.png);
    else: attr(data-foo);))' with data-foo="https://does-not-exist-2.test/404.png": FAIL (Chrome: PASS, Safari: FAIL)
  • 'background-image: image-set(if(style(--true): url(https://does-not-exist.test/404.png);
    style(--condition-val): url(https://does-not-exist.test/404.png);
    else: url(https://does-not-exist.test/404.png);))' with data-foo="attr(data-foo type(*))": FAIL (Chrome: PASS, Safari: FAIL)
  • '--x: image-set(if(style(--condition-val: if(style(--true): attr(data-foo type(*));)): url(https://does-not-exist.test/404.png);))' with data-foo="3": FAIL (Chrome: PASS, Safari: FAIL)
  • '--x: image-set(if(style(--condition-val >= attr(data-foo type(*))): url(https://does-not-exist.test/404.png);))' with data-foo="3": FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b047c25a7e1c
https://hg.mozilla.org/integration/autoland/rev/9a28226cd610
[wpt PR 53286] - Carry attr-tainting through if() style ranges, a=testonly
https://github.com/mozilla-firefox/firefox/commit/318cce0630a0
https://hg.mozilla.org/integration/autoland/rev/a80601280439
[wpt PR 53286] - Update wpt metadata, a=testonly

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/9a28226cd610
https://hg.mozilla.org/mozilla-central/rev/a80601280439