1973324 - Switched to home when reopening through launcher

Status: VERIFIED FIXED

(Firefox for Android :: Homepage, defect, P1)

Description

[Roger Yang [:royang]]

Attachment: Screen_recording_20250620_221548.mp4

Steps to reproduce

With PBM lock feature disabled:

1. Open a private tab
2. Switch to Android OS home screen
3. Tap on the Firefox Nightly icon in launcher to go back into Firefox Nightly.

Expected behavior

4. See the last opened private tab.

Actual behavior

4. Flashes and see private tab home.
5. Doing the same thing one more time then see normal home.

Device information

• Firefox version: v141
• Android device model:
• Android OS version:

Any additional information?

Comment 1

[Roger Yang [:royang]]

:Gela This is found on v141.0a1-20250617143356. Not sure if this is already fixed by in progress reviews but thought I'll open the bug just in case.

Comment 2

[:Gela]

Thanks for filing this. I gave it a go on different builds and here are the results:

• Can reproduce on the Nightly from Play Store
• Can reproduce on the most recent Main if I set the build variant to Nightly
• Cannot reproduce on Beta

Comment 3

[:Gela]

After further discussions, we don't think it's related to the PBM changes for the following reasons:

1. This happens regardless of whether or not PBM lock is enabled
2. This does not reproduce on Beta where we have all the PBM related changes uplifted to, only happens on Nightly.
3. There are other similar bugs related to this already filed for Homepage/Toolbar here and here.

So I'm going to move this to the appropriate component and move out of the PBM lock meta.

Comment 4

[:Gela]

Possibly related to changes from https://bugzilla.mozilla.org/show_bug.cgi?id=1968048

Comment 5

[Roger Yang [:royang]]

Confirmed reverting the change in https://bugzilla.mozilla.org/show_bug.cgi?id=1968048 the issue is resolved. Marking this as the regressor.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

:gl, since you are the author of the regressor, bug 1968048, could you take a look?

For more information, please visit BugBot documentation.

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1973324 - Part 1: Persists private mode when the user is still in private mode and has private tabs opened on warm start

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1973324 - Part 2: Refactor setting the appropriate browsing mode into BrowsingModeManger

• Refactors HomeActivity.getModeFromIntentOrLastKnown into BrowsingModeManger. This moves more of the logic related to computing the browsing mode from the provided intent, last known mode settings and number of private tabs opened into BrowsingModeManger and out of the HomeActivity.
• Introduces a public BrowsingModeManager.updateMode function for updating the browsing mode with a new Intent.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6a8d3ef03e14
https://hg.mozilla.org/integration/autoland/rev/974534c78831
Part 1: Persists private mode when the user is still in private mode and has private tabs opened on warm start r=android-reviewers,Roger
https://github.com/mozilla-firefox/firefox/commit/2af7989dd9da
https://hg.mozilla.org/integration/autoland/rev/370ef56195ba
Part 2: Refactor setting the appropriate browsing mode into BrowsingModeManger r=Roger,android-reviewers

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/974534c78831
https://hg.mozilla.org/mozilla-central/rev/370ef56195ba

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gl, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox141 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Lorand Janos]

Verified as fixed in the latest Nightly build (142.0a1 from 2025-07-01);

The last opened tab is displayed when going back to the app with a page open in PB.

Device used: Samsung Galaxy S23 Ultra (Android 15).

Marking as verified on 142.

Comment 13

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9497543 [details]
Bug 1973324 - Part 1: Persists private mode when the user is still in private mode and has private tabs opened on warm start

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: This will persist private mode when the user reopens Fenix when they in a warm start, which would otherwise restart user back in normal browsing mode.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk because it is covered by tests and QA has verified in Nightly.
• String changes made/needed:
• Is Android affected?: Yes

Comment 14

[Pascal Chevrel:pascalc]

Gabriel, you requested uplift in the bug only for part 1 of the fix, does part 2 also needs to be uplifted? Thanks

Comment 15

[Gabriel Luong [:gl] (ΦωΦ)]

Part 2 is not needed for the fix in the uplift. Thanks!

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/7c4b465a02be
https://hg.mozilla.org/releases/mozilla-beta/rev/5c01b2a4c2a8

Comment 17

[Lorand Janos]

Verified as fixed in the latest Beta build as well (141.0b6);

The last opened tab is displayed when going back to the app with a page open in PB.

Device used: Samsung Galaxy S23 Ultra (Android 15).

Marking as verified on 141.

Comment 18

[Adina Petridean QA [:apetridean]]

Attachment: 2025-07-08-11-52-49(1).mp4

Verified as fixed in Firefox 141.0b7 with Asus Zenfone 9 (Android 13).