1973366 - Replace all existing usage of HomeActivity#openToBrowserAndLoad with FenixBrowserUseCases#loadUrlOrSearch

Status: ASSIGNED

(Firefox for Android :: Homepage, task, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

In Bug 1950555, we introduced FenixBrowserUseCases#loadUrlOrSearch to replace the existing usage of openBrowserToBrowserAndLoad. See the original bug for the rationale and context.

This task in this bug continues the refactoring so that we will be able to open all URLs in any of the Fenix UI to take advantage of the new FenixBrowserUseCases and allow us to open URLs in the existing tab as part of Homepage as a New Tab.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1973366 - Part 1: Refactor opening stories to use `FenixBrowserUseCases.loadUrlOrSearch`

• Refactors the existing usage of HomeActivity.openToBrowserAndLoad in PocketStoriesController to use FenixBrowserUseCases.loadUrlOrSearch.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1973366 - Part 2: Remove unused `homeFragment` parameter in `HomeMenuView`

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1973366 - Part 3: Refactoring opening URLs from the Homepage Menu to use `FenixBrowserUseCases.loadUrlOrSearch`

• Refactors the existing usage of HomeActivity.openToBrowserAndLoad in HomeMenuView to use FenixBrowserUseCases.loadUrlOrSearch and considers whether or not the URL should be opened in a new tab depending on whether or not Homepage as a New Tab is enabled.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5fdb88b14f2f
https://hg.mozilla.org/integration/autoland/rev/ffaec9498262
Part 1: Refactor opening stories to use `FenixBrowserUseCases.loadUrlOrSearch` r=android-reviewers,devota
https://github.com/mozilla-firefox/firefox/commit/3faeef4ea1f8
https://hg.mozilla.org/integration/autoland/rev/e458c3af291e
Part 2: Remove unused `homeFragment` parameter in `HomeMenuView` r=android-reviewers,devota

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/ffaec9498262
https://hg.mozilla.org/mozilla-central/rev/e458c3af291e

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1973366 - Part 4: Refactoring opening collections on the homepage to use `FenixBrowserUseCases.loadUrlOrSearch`

• Refactors the existing usage of HomeActivity.openToBrowserAndLoad in handleCollectionOpenTabClicked to use FenixBrowserUseCases.loadUrlOrSearch.
• Open collection tab in existing tab when Homepage as a New Tab is enabled.

Comment 7

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1973366 - Part 5: Refactoring toolbar paste and go menu option to use `FenixBrowserUseCases.loadUrlOrSearch`

• Refactors the existing usage of HomeActivity.openToBrowserAndLoad in DefaultToolbarController.handlePasteAndGo to use FenixBrowserUseCases.loadUrlOrSearch.
• Paste and go menu item should open in the existing tab when Homepage as a New Tab is enabled.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9eaa3cbfe00f
https://hg.mozilla.org/integration/autoland/rev/12d679cc6f7c
Part 3: Refactoring opening URLs from the Homepage Menu to use `FenixBrowserUseCases.loadUrlOrSearch` r=android-reviewers,pollymce
https://github.com/mozilla-firefox/firefox/commit/a7c1e1278a47
https://hg.mozilla.org/integration/autoland/rev/e1df2ac7c5ed
Part 4: Refactoring opening collections on the homepage to use `FenixBrowserUseCases.loadUrlOrSearch` r=android-reviewers,pollymce
https://github.com/mozilla-firefox/firefox/commit/94aa6fcc03c5
https://hg.mozilla.org/integration/autoland/rev/8f00ed883a6a
Part 5: Refactoring toolbar paste and go menu option  to use `FenixBrowserUseCases.loadUrlOrSearch` r=android-reviewers,petru

Comment 9

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/12d679cc6f7c
https://hg.mozilla.org/mozilla-central/rev/e1df2ac7c5ed
https://hg.mozilla.org/mozilla-central/rev/8f00ed883a6a