1973395 - Move and tidy output and splash code from output-window.js to static.js in cZ

Status: RESOLVED FIXED

(SeaMonkey :: Chat, task)

Description

[Ian Neal]

At the moment the setting of the splash name and adding the messages in the chat window is done in output-window.js, this could equally be done in static.js. Whilst here remove the unused initialized variable in output-windows.js and tidy up the code being moved.

Comment 1

[Ian Neal]

Attachment: 1973395-irc-move-splash-output-25322.patch

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: none
Testing completed (on m-c, etc.): 2.53.22pre
Risk to taking this patch (and alternatives if risky): low
String changes made by this patch: none

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9496174 [details] [diff] [review]
1973395-irc-move-splash-output-25322.patch

With this patch in the topic is no longer shown in #seamonkey. Only unknown is displayed in both modern and classic theme.

Comment 3

[Ian Neal]

Attachment: 1973395-irc-move-splash-output-v1_1-25322.patch

Fixed the issue with how there were multiple ways of checking the window had been initialized and unnecessary repeated calls to update the header. Did some more tidying whilst here.

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9497900 [details] [diff] [review]
1973395-irc-move-splash-output-v1_1-25322.patch

LGTM r/a+

There were some discussions in #seamonkey about motif css not sticking. Could the removed changeCSS(view.prefs["motif.current"]) have caused this?

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c46748afbbd4
Move and tidy output and splash code from output-window.js to static.js in cZ. r=frg DONTBUILD