1973494 - Command & CommandFor only allows custom values starting with `--`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Keith Cirkel [:keithamus]]

"Custom values" are considered to have a - anywhere in the string, but this is not per spec, the spec dictates that custom command keywords should start with a double dash (--).

https://html.spec.whatwg.org/multipage/form-elements.html#attr-button-command-custom

Comment 1

[Keith Cirkel [:keithamus]]

Attachment: Bug 1973494 - Only mark Custom commands as attrs that start with two dashes r?#dom-core

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/41e61fa7f53f
https://hg.mozilla.org/integration/autoland/rev/4aaedf3cc515
Only mark Custom commands as attrs that start with two dashes r=dom-core,edgar

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f853b72f0f22
https://hg.mozilla.org/integration/autoland/rev/a10a9cf354cc
Revert "Bug 1973494 - Only mark Custom commands as attrs that start with two dashes r=dom-core,edgar" for causing wpt failures @ command-and-commandfor/on-dialog-behavior.html

Comment 4

[amarc]

Backed out for causing wpt failures @ on-dialog-behavior.html

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bdea3b40442d
https://hg.mozilla.org/integration/autoland/rev/1d5f48ffdf9d
Only mark Custom commands as attrs that start with two dashes r=dom-core,edgar

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1d5f48ffdf9d