1973497 - Command & Commandfor: form buttons must explictly set type=button to be command buttons

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Keith Cirkel [:keithamus]]

Button activation behaviour requires command & commandfor to be ignored if the button is a form participant without an explicit button type content attribute. Trunk currently dispatches command events for buttons with command/commandfor regardless of type.

Comment 1

[Keith Cirkel [:keithamus]]

Attachment: Bug 1973497 - Refactor HTMButtonElement::ActivationBehavior r?#dom-core

This refactoring aligns the button activation behaviour to the exact
steps specified in HTML, which has some small changes from the prior
implementation:

• button activation returns early after submitting, or resetting, not
  triggering popovers or command/commandfor.
• buttons with form owners and a type attribute in the Auto state must
  return early, not triggering popovers or command/commandfor.

This also has some other non-observable changes to the code:

• collapses the HandleCommandForAction method directly into
  ActivationBehavior.
• adds code comments for each of the spec steps

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6282a5468b41
https://hg.mozilla.org/integration/autoland/rev/16ecb9de093b
Refactor HTMButtonElement::ActivationBehavior r=dom-core,edgar

Comment 3

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/16ecb9de093b