Closed Bug 1973538 Opened 10 months ago Closed 10 months ago

[wpt-sync] Sync PR 53326 - Initial parsing+storage of border-shape

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
142 Branch
Tracking Flags:
Tracking Status
firefox142 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53326 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53326
Details from upstream follow.

Noam Rosenthal <nrosenthal@chromium.org> wrote:

Initial parsing+storage of border-shape

Setup the runtime flags and basic parsing.
Not overdoing it with parsing tests yet, as the syntax might change,
and the first objective is to prototype something demo-able.

Parsing two basic shapes and storing as 0-2 BasicShapes in a new
StyleBorderShape class.

Note that the single-shape variant is equivalent to the two-shape
variant when the two shapes are identical. This makes animating
between the two variants possible. The details of this will be fleshed
out at CSSWG after prototyping.

Chrome Status: https://chromestatus.com/feature/5459864205393920

Explainer: https://github.com/noamr/explainers/blob/main/border-shape-explainer.md
Spec: https://drafts.csswg.org/css-borders-4/#border-shape
Bug: 370041145
Change-Id: I923d266b28c8098f58065fa0c18e1782a99d5446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6651904
Commit-Queue: Noam Rosenthal \<nrosenthal@google.com>
Reviewed-by: Fredrik Söderquist \<fs@opera.com>
Cr-Commit-Position: refs/heads/main@{#1477304}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 3 tests and 6 subtests

Status Summary

Firefox

OK : 3
PASS: 5
FAIL: 12

Chrome

OK : 3
PASS: 5
FAIL: 12

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-borders/tentative/parsing/border-shape-computed.html [wpt.fyi]
    • Property border-shape value 'none': FAIL (Chrome: FAIL)
    • Property border-shape value 'circle()': FAIL (Chrome: FAIL)
    • Property border-shape value 'polygon(10px 10px, 100px 10px, 10px 100px)': FAIL (Chrome: FAIL)
    • Property border-shape value 'shape(from 0px 0px, hline to 100px, vline to 100px, close)': FAIL (Chrome: FAIL)
    • Property border-shape value 'circle() circle()': FAIL (Chrome: FAIL)
    • Property border-shape value 'circle() polygon(10px 10px, 100px 10px, 10px 100px)': FAIL (Chrome: FAIL)
  • /css/css-borders/tentative/parsing/border-shape-valid.html [wpt.fyi]
    • e.style['border-shape'] = "none" should set the property value: FAIL (Chrome: FAIL)
    • e.style['border-shape'] = "circle()" should set the property value: FAIL (Chrome: FAIL)
    • e.style['border-shape'] = "polygon(10px 10px, 100px 10px, 10px 100px)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['border-shape'] = "shape(from 0px 0px, hline to 100px, vline to 100px, close)" should set the property value: FAIL (Chrome: FAIL)
    • e.style['border-shape'] = "circle() circle()" should set the property value: FAIL (Chrome: FAIL)
    • e.style['border-shape'] = "circle() polygon(10px 10px, 100px 10px, 10px 100px)" should set the property value: FAIL (Chrome: FAIL)

https://hg.mozilla.org/mozilla-central/rev/5c787f8eced8
https://hg.mozilla.org/mozilla-central/rev/51f251cb1058

Status: NEW → RESOLVED
Closed: 10 months ago
status-firefox142: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
You need to log in before you can comment on or make changes to this bug.