1973547 - [wpt-sync] Sync PR 53328 - [animation-trigger] Use consistent pixel spaces

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53328 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53328
Details from upstream follow.

David Awogbemila <[e-mail]> wrote:

[animation-trigger] Use consistent pixel spaces

The animation trigger code stored ranges created by script in CSS
pixels and ranges created by CSS in physical pixels. It also wrongly
mixed pixel spaces when evaluating whether a scroll offset was within
the trigger range.

This patch fixes this by ensuring that
AnimationTrigger::{exit}range{Start,End} is consistently stored in CSS
pixels and handles the conversion between CSS pixels and physical
pixels when evaluating a given scroll offset.

Bug: 424448496, 390314945
Change-Id: I7ce4ab4a9f607238613d9d8e1b612f15f9b2b0b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6652464
Reviewed-by: Vladimir Levin \<[e-mail]>
Commit-Queue: David Awogbemila \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1477340}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f59c700be7a2c0005020c934e0c41114cf89656

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
PASS: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /scroll-animations/animation-trigger/animation-trigger-range-px-roundtrip.tentative.html [wpt.fyi]
  • Ranges of triggers created by script are read in CSS pixels: FAIL (Chrome: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9163ed14cb18
https://hg.mozilla.org/integration/autoland/rev/8d74ff53291d
[wpt PR 53328] - [animation-trigger] Use consistent pixel spaces, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/8d74ff53291d