Closed
Bug 1973596
Opened 8 months ago
Closed 8 months ago
Evaluate std::variant compared to mozilla::Variant
Categories
(Core :: MFBT, task)
Core
MFBT
Tracking
()
RESOLVED
FIXED
142 Branch
| Tracking | Status | |
|---|---|---|
| firefox142 | --- | fixed |
People
(Reporter: sergesanspaille, Assigned: sergesanspaille)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We have our own version of std::variant, and it's quite code-heavy. It would be grat if we could use std::variant instead.
|
||
Updated•8 months ago
|
Summary: Evaluate std::variant compated to mozilla::Variant → Evaluate std::variant compared to mozilla::Variant
|
Assignee | |
Comment 1•8 months ago
|
||
Long story short I gave a try at the migration, it's possible to do it
but requires a significant API change, leads to larger code (both
textual and binary) and we loose some nice constness property due to
different assignment semantic.
So basically not a good idea, document it.
|
||
Updated•8 months ago
|
Assignee: nobody → sguelton
Status: NEW → ASSIGNED
|
|
||
Updated•8 months ago
|
Attachment #9496389 -
Attachment description: Bug 1973596 - Document conceptual difference between std and mozilla variant r=nika → Bug 1973596 - Document conceptual difference between std and mozilla variant r=nika!
Pushed by sguelton@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/75c40aad57a9
https://hg.mozilla.org/integration/autoland/rev/1245326ba546
Document conceptual difference between std and mozilla variant r=glandium
|
||
Comment 3•8 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
status-firefox142:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
|
||
Updated•7 months ago
|
QA Whiteboard: [qa-triage-done-c143/b142]
You need to log in
before you can comment on or make changes to this bug.
Description
•