1973650 - [wpt-sync] Sync PR 53341 - Reland "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53341 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53341
Details from upstream follow.

Johannes Henkel <[e-mail]> wrote:

Reland "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries"

This reverts commit bccaa635d365e6d91365a89c44481ab757aaa49b.

Reason for revert: I think I fixed the flakiness. :-)

Original change's description:

Revert "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries"

This reverts commit ae18e2a905e16727ae7c4e55988095c085cd09aa.

Reason for revert: Flaky on Linux bots due to race condition between rAF and presentation time callbacks. https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Aheadless_shell_wpt%2Fexternal%2Fwpt%2Fsoft-navigation-heuristics%2Flcp%2Ftentative%2Fraf-loop.html

Original change's description:

[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries

This tests that a click handler invocation which leads to the detection
of a soft navigation may defer some work with requestAnimationFrame, and
that work can generate additional soft LCP performance entries.

Change-Id: Ic432a8fed21a2836c122e6c1d7ba38150c901753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6651298
Commit-Queue: Johannes Henkel \<[e-mail]>
Reviewed-by: Annie Sullivan \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1475225}

Change-Id: I866e47960f614817a26d14476098dbfe44021ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6657418
Bot-Commit: Rubber Stamper \<[e-mail]>
Reviewed-by: Michal Mocny \<[e-mail]>
Commit-Queue: Scott Haseley \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1476288}

Change-Id: Ic4615afa1b68461e5fad846304d49c44dfd2026c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6658297
Reviewed-by: Scott Haseley \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Johannes Henkel \<[e-mail]>
Reviewed-by: Michal Mocny \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1477725}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 53341 applied with additional changes from upstream: f6a6f9b58259800fb76911912ac0692df5db264e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

TIMEOUT: 2

Chrome

TIMEOUT: 2

Safari

OK : 1
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /soft-navigation-heuristics/lcp/tentative/raf-loop.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: OK)
  • Largest Contentful Paint after soft navigation: requestAnimationFrame can add additional LCP entry.: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /soft-navigation-heuristics/lcp/tentative/raf-loop.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-32-24h2-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c0cb267d797f
https://hg.mozilla.org/integration/autoland/rev/468a7cb63683
[wpt PR 53341] - Reland "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries", a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/468a7cb63683