Closed Bug 1973651 Opened 6 months ago Closed 6 months ago

Try to recover from invalid cookies in the DB

Categories

(Core :: Networking: Cookies, task, P2)

Product:
Core
Component:
Networking: Cookies
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
142 Branch
Tracking Flags:
Tracking Status
firefox142 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1973651 - Try to recover from invalid cookies in the DB, r?valentin
48 bytes, text/x-phabricator-request
Details | Review

We introduced nsICookieValidation recently (bug 1955685). In bug 1972513, we added telemetry to identify the most common validation issues in the Cookie DB. This bug aims to implement recovery logic for certain cookie validation errors—specifically, the eRejectedNoneRequiresSecure case.

Assignee: nobody → amarchesini
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged]
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/fe611fe93d3e https://hg.mozilla.org/integration/autoland/rev/33ef8a46abc6 Revert "Bug 1973651 - Try to recover from invalid cookies in the DB, r=valentin,cookie-reviewers" for causing bp-nu bustages in CookiePersistentStorage.cpp.

In reply to comment 3.

Reverted this because it was causing bp-nu bustages in CookiePersistentStorage.cpp.

  • Revert link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/netwerk/cookie/CookiePersistentStorage.cpp:2388:10: error: unknown type name 'CookieService'; did you mean 'nsICookieService'?
Regressions: 1974014

https://hg.mozilla.org/mozilla-central/rev/850ed95c8816

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox142: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
See Also: → 1974987
QA Whiteboard: [qa-triage-done-c143/b142]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: