1973654 - Refactor the buffer allocator in preparation for arbitrarily sized small buffers

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P1)

Description

[Jon Coppeard (:jonco)]

The patch stack for bug 1973033 got too large so I'm splitting out a bunch of refactoring work into this bug.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1973654 - Part 1: Split out AtomicBitmap and simplify MarkBitmap r?sfink

We're using the mark bitmap in the buffer allocator but we don't use most of
the methods. Simplify things by splitting out a separate class AtomicBitmap and
use that instead.

We can them remove the templates from MarkBitmap and use this directly in
chunks.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1973654 - Part 2: Remove unnecessary takeOrAllocChunk and rename emplace to init r?sfink

Not related to the buffer allocator, but I noticed that getOrAllocChunk has
only a single caller. This patch combines the two methods.

Also this renames the 'emplace' method to the simpler 'init'.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1973654 - Part 3: Refactor BufferAllocator::addFreeRegion to move the size class calculation inside r?sfink

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1973654 - Part 4: Combine BufferAllocator::allocSmall and allocSmallInGC r?sfink

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1973654 - Part 5: Move findFollowing/PreviousFreeRegion methods to BufferChunk r?sfink

Comment 6

[Jon Coppeard (:jonco)]

Attachment: Bug 1973654 - Part 6: Refactor bitmap/array operations on BufferChunk r?sfink

This commons up some assertions and simplifies the bitmap and array accessors.

Comment 7

[Jon Coppeard (:jonco)]

Attachment: Bug 1973654 - Part 7: Replace use of min size with granularity where appropriate r?sfink

Comment 8

[Jon Coppeard (:jonco)]

Attachment: Bug 1973654 - Part 8: Make BufferChunkIter an inner class of BufferChunk and simplify it r?sfink

This can be simplified by marking it work in terms of bit index rather than
converting back and forth from byte offsets all the time.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5d4999e82db8
https://hg.mozilla.org/integration/autoland/rev/20280fc54582
Part 1: Split out AtomicBitmap and simplify MarkBitmap r=sfink
https://github.com/mozilla-firefox/firefox/commit/3196aeb106cb
https://hg.mozilla.org/integration/autoland/rev/7b84a0ec0400
Part 2: Remove unnecessary takeOrAllocChunk and rename emplace to init r=sfink
https://github.com/mozilla-firefox/firefox/commit/8165915de6f8
https://hg.mozilla.org/integration/autoland/rev/4c89ad2d94ed
Part 3: Refactor BufferAllocator::addFreeRegion to move the size class calculation inside r=sfink
https://github.com/mozilla-firefox/firefox/commit/40a5d5dabd3f
https://hg.mozilla.org/integration/autoland/rev/56b737163e0e
Part 4: Combine BufferAllocator::allocSmall and allocSmallInGC r=sfink
https://github.com/mozilla-firefox/firefox/commit/a7e158f917ff
https://hg.mozilla.org/integration/autoland/rev/8e568a61e5ab
Part 5: Move findFollowing/PreviousFreeRegion methods to BufferChunk r=sfink
https://github.com/mozilla-firefox/firefox/commit/4d962aa9aad7
https://hg.mozilla.org/integration/autoland/rev/4f85cf27c6cd
Part 6: Refactor bitmap/array operations on BufferChunk r=sfink
https://github.com/mozilla-firefox/firefox/commit/675353147ee6
https://hg.mozilla.org/integration/autoland/rev/8687dfc6943d
Part 7: Replace use of min size with granularity where appropriate r=sfink
https://github.com/mozilla-firefox/firefox/commit/d76a5621f42e
https://hg.mozilla.org/integration/autoland/rev/a38aa536aa36
Part 8: Make BufferChunkIter an inner class of BufferChunk and simplify it r=sfink
https://github.com/mozilla-firefox/firefox/commit/ee5adb5fe585
https://hg.mozilla.org/integration/autoland/rev/386a713dc309
apply code formatting via Lando

Comment 10

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/20280fc54582
https://hg.mozilla.org/mozilla-central/rev/7b84a0ec0400
https://hg.mozilla.org/mozilla-central/rev/4c89ad2d94ed
https://hg.mozilla.org/mozilla-central/rev/56b737163e0e
https://hg.mozilla.org/mozilla-central/rev/8e568a61e5ab
https://hg.mozilla.org/mozilla-central/rev/4f85cf27c6cd
https://hg.mozilla.org/mozilla-central/rev/8687dfc6943d
https://hg.mozilla.org/mozilla-central/rev/a38aa536aa36
https://hg.mozilla.org/mozilla-central/rev/386a713dc309