Closed
Bug 1973669
Opened 1 month ago
Closed 1 month ago
NavigationResult::mCommitted must be non-null, but is assigned the result of Promise::CreateRejected
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
DUPLICATE
of bug 1973015
People
(Reporter: tschuster, Unassigned)
References
(Regression)
Details
(Keywords: regression)
It seems like Promise::CreateRejected can return a nullptr, but NavigationResult's mCommitted and mFinished are
declared as NonNull: https://searchfox.org/mozilla-central/source/__GENERATED__/dist/include/mozilla/dom/NavigationBinding.h#125
|
Reporter | |
Updated•1 month ago
|
Summary: NavigationResult::mCommitted must be non-null, but is assigned Promise::CreateRejected → NavigationResult::mCommitted must be non-null, but is assigned the result of Promise::CreateRejected
|
|
Reporter | |
Updated•1 month ago
|
Flags: needinfo?(jjaschke)
|
||
Comment 1•1 month ago
|
||
I think the only (realistic?) cases in which that could happen would be OOM. However, since the original patch got backed out, I'll replace it with Promise::CreateInfallible(), which would crash in error cases.
Closing this as dupe because I'm fixing it in the original bug.
Status: NEW → RESOLVED
Closed: 1 month ago
Duplicate of bug: 1973015
Flags: needinfo?(jjaschke)
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•