1973689 - [wpt-sync] Sync PR 53349 - [line-clamp] Make text-wrap: balance work with the line-clamp ellipsis

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53349 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53349
Details from upstream follow.

Andreu Botella <[e-mail]> wrote:

[line-clamp] Make text-wrap: balance work with the line-clamp ellipsis

(This CL is an alternative approach to the crrev.com/c/6543867,
crrev.com/c/6544146 and crrev.com/c/6543587 relation chain.)

With the LineClampLineBreakingEllipsis flag, which takes into
account the width of the line-clamp ellipsis during line breaking,
this width must be passed into the LineBreaker instance, since it
can't compute it based on the inline items.

This is handled when LineBreaker is used in InlineLayoutAlgorithm,
but it isn't when it is used in ScoreLineBreaker and
ParagraphLineBreaker to implement text-wrap: {balance,pretty}. To
make text-wrap: balance handle the ellipsis properly, we choose to
only implement this handling in ParagraphLineBreaker, so we disable
score line breaking when line clamping. In order to determine the
ellipsis width in ParagraphLineBreaker, we also add an
InlineLayoutAlgorithm::ShapeLineClampEllipsis static method.

Although this CL does not add any support for line-clamp together
with text-wrap: pretty, while working on this patch we noticed a
crash when those two features were used together. As a result, this
patch also adds a text-wrap: pretty crash test.

Bug: 40336192
Change-Id: I5cbaa2d89fb8eef58908ebfe35ef356c4de24cfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641006
Reviewed-by: Koji Ishii \<[e-mail]>
Commit-Queue: Andreu Botella \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1477817}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b85e71d4bcfb75d612f417eb1ac2c8aa0bca6e5

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 3 tests

Status Summary

Firefox

FAIL: 3

Chrome

FAIL: 3

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-text/white-space/text-wrap-balance-line-clamp-002.html [wpt.fyi]: FAIL (Chrome: FAIL)
• /css/css-text/white-space/text-wrap-balance-line-clamp-003.html [wpt.fyi]: FAIL (Chrome: FAIL)
• /css/css-text/white-space/text-wrap-balance-line-clamp-004.html [wpt.fyi]: FAIL (Chrome: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b27a2fd9420c
https://hg.mozilla.org/integration/autoland/rev/f9e98577c600
[wpt PR 53349] - [line-clamp] Make text-wrap: balance work with the line-clamp ellipsis, a=testonly
https://github.com/mozilla-firefox/firefox/commit/43bf09d198b8
https://hg.mozilla.org/integration/autoland/rev/774ba1d96145
[wpt PR 53349] - Update wpt metadata, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/f9e98577c600
https://hg.mozilla.org/mozilla-central/rev/774ba1d96145