1973721 - about:addons search textbox has shrunk and is now clipping the contents resulting in "mozilla.or" despite there being sufficient space

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Kestrel]

Attachment: Clipped textbox contents on about:addons

STR:

1. Visit about:addons on Ubuntu 25.04.
2. See the search textbox in the top right corner.

Expected:
Full address is shown without clipping.

Actual:
Partial address shown with wrong TLD, mozilla.or instead of mozilla.org. It is not obvious that clipping is occurring since there is no fading or ellipses and there appears to be sufficient space.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=91c04ab1b071ae92976a7390f06669b54cbf4ccd&tochange=2158a58d807791d3e301438d289c0d74eea0a2d3

Regressed by Bug 1968916.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1968916, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1973721 - Reduce end padding on search input. r=#reusable-components-reviewers

Since there's a clear button taking space too.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1973721 - Use text-overflow: ellipsis on <moz-input-text> placeholder. r=#reusable-components-reviewers

So that it's clear when there's overflow.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1973721 - Increase size of addon search input. r=#extension-reviewers

The regressing bug increased the font-size effectively, which causes the
placeholder to overflow.

Grow it a bit more.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6bad12242714
https://hg.mozilla.org/integration/autoland/rev/49d4a57168bb
Reduce end padding on search input. r=reusable-components-reviewers,tgiles
https://github.com/mozilla-firefox/firefox/commit/f644a6fdb95c
https://hg.mozilla.org/integration/autoland/rev/526330227c51
Use text-overflow: ellipsis on <moz-input-text> placeholder. r=reusable-components-reviewers,tgiles
https://github.com/mozilla-firefox/firefox/commit/4fe595cc2ce0
https://hg.mozilla.org/integration/autoland/rev/0ac8c58a0190
Increase size of addon search input. r=extension-reviewers,robwu

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/49d4a57168bb
https://hg.mozilla.org/mozilla-central/rev/526330227c51
https://hg.mozilla.org/mozilla-central/rev/0ac8c58a0190

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox141 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9496524 [details]
Bug 1973721 - Reduce end padding on search input. r=#reusable-components-reviewers

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Regression fix.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple css changes.
• String changes made/needed: none
• Is Android affected?: No

Comment 9

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

I was able to reproduce the issue with an affected Firefox 141.0b2 build on Ubuntu 22.04, Windows 11 and macOS 14, as described in Comment 0.
Verified as fixed using Firefox Nightly 142.0a1 (2025-06-27) on Ubuntu 22.04, Windows 11 and macOS 14. Search textbox from about:addons is no longer clipped.

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/fe79491d3569
https://hg.mozilla.org/releases/mozilla-beta/rev/328ca6bc1e63
https://github.com/mozilla-firefox/firefox/commit/45d2df9abe9f
https://hg.mozilla.org/releases/mozilla-beta/rev/b1c00b5baf62
https://github.com/mozilla-firefox/firefox/commit/170df498975e
https://hg.mozilla.org/releases/mozilla-beta/rev/04729c9ca8b8

Comment 11

[Bianca Hidecuti, Desktop Test Engineering [:bhidecuti]]

(In reply to Bianca Hidecuti, Desktop Test Engineering [:bhidecuti] from comment #9)

I was able to reproduce the issue with an affected Firefox 141.0b2 build on Ubuntu 22.04, Windows 11 and macOS 14, as described in Comment 0.
Verified as fixed using Firefox Nightly 142.0a1 (2025-06-27) on Ubuntu 22.04, Windows 11 and macOS 14. Search textbox from about:addons is no longer clipped.

Verified as fixed using Firefox 141.0b5 (treeherder build from Comment 10) on Ubuntu 22.04, Windows 11 and macOS 14 as well.