1973748 - Input range not working by the dot anymore

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Marian]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:134.0) Gecko/20100101 Firefox/134.0

Steps to reproduce:

Make a Input Range and disable mouse click event over the trace.

input[type="range"] {
pointer-events: none;
}
input[type="range"]::-moz-range-thumb {
pointer-events: all;
}

Actual results:

Now I can't drag the dot to use the slider.

Expected results:

Previously, I can drag the dot to use the slider.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::Browser Engine' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Gregory Pappas [:gregp]]

Attachment: testcase.html

Comment 3

[Gregory Pappas [:gregp]]

Last good revision: 87e010ebac62c5bed9a41c64e63df5be347f65e6
First bad revision: 2a6675e95277b3795a774a09e529ae8566eee68e
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=87e010ebac62c5bed9a41c64e63df5be347f65e6&tochange=2a6675e95277b3795a774a09e529ae8566eee68e

Comment 4

[Gregory Pappas [:gregp]]

Attachment: testcase.html: add ::-webkit-slider-thumb for testing behavior in other browsers

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1971450, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 6

[Marian]

I was using that like a workaround when trying to scroll and touch it, it's changes the value.
Maybe that would be better to remove the touch-press to not change the value, and when the touch-release is made.
And when touch-press is and the scroll was made to disable the input-change.

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1973748 - Let range thumb be hittable for events. r=tnikkel,#layout

This restores this thumb-drawing code1, but only for hit testing
(since we don't need it when painting the themed range to the screen).

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1971450

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37a5f4c8567b
https://hg.mozilla.org/integration/autoland/rev/6cc327ecd637
Let range thumb be hittable for events. r=tnikkel,layout-reviewers

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6cc327ecd637

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox141 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9500139 [details]
Bug 1973748 - Let range thumb be hittable for events. r=tnikkel,#layout

Beta/Release Uplift Approval Request

• User impact if declined/Reason for urgency: Regression fix.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple fix.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 13

[Mira Lobontiu (Android QA)]

Attachment: Screen_Recording_20250718_105644_Firefox Nightly.mp4

Verified as fixed on the latest Firefox for Android nightly 142.0a1 from 7/17, with a Samsung Galaxy S24 (Android 15) device.

Comment 14

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/e83b700a564b
https://hg.mozilla.org/releases/mozilla-release/rev/4d2187d19905