Closed Bug 1973750 Opened 10 months ago Closed 10 months ago

[wpt-sync] Sync PR 53355 - Fix logic for pending animations waiting on a start time.

Categories

(Core :: DOM: Animation, task, P4)

task

Tracking

()

RESOLVED FIXED
142 Branch
Tracking Status
firefox142 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53355 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53355
Details from upstream follow.

Kevin Ellis <kevers@google.com> wrote:

Fix logic for pending animations waiting on a start time.

A previous change introduced a regression, by erroneously assuming
that an animation that was scheduled to start in an earlier frame
would be already on the "waiting for start time" list. A composited
animation could be modified in such a way that it picks up a new
compositor group, and thus it will no longer match when the group
gets its start notification. A composited animation that is not
synchronized to align its start time with new animations, must
be re-added to the wait list if its compositor group changed.

Bug: 426470286, 420734136
Change-Id: I3038bab22b49b73a2d07e152738bc29d300a0672
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6662920
Reviewed-by: Vladimir Levin \<vmpstr@chromium.org>
Commit-Queue: Kevin Ellis \<kevers@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1477937}

Component: web-platform-tests → DOM: Animation
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests and 7 subtests

Status Summary

Firefox

OK : 1
PASS: 7

Chrome

OK : 1
PASS: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0469be26f74a https://hg.mozilla.org/integration/autoland/rev/74465010419b [wpt PR 53355] - Fix logic for pending animations waiting on a start time., a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
You need to log in before you can comment on or make changes to this bug.