Open Bug 1973768 Opened 3 days ago Updated 3 days ago

[wpt-sync] Sync PR 53356 - Rename interesttarget attribute and friends

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(2 files)

Sync web-platform-tests PR 53356 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53356
Details from upstream follow.

Mason Freed <masonf@chromium.org> wrote:

Rename interesttarget attribute and friends

**** GARDENERS: Please note! ****
Please do me a huge favor and don't revert this CL if there are a
few test flakes after landing it. Instead, please just mark those
tests as flaky/fail and assign me a bug and I'll get it cleaned up.
Thanks in advance!


There have been a few standards conversations about naming:

Per those conversations, this CL renames the following:

  • the interesttarget attribute becomes the interestfor attribute
  • interestTargetElement -> interestForElement
  • CSS interest-target-*-delay -> interest-*-delay

I also renamed the feature flags and associated code, so that the new
names are code-searchable. I did not rename the IDS string var names,
so that we don't waste time on re-translating them.

Bug: 364669918

AX-Relnotes: Just renaming the attribute
Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6626064
Reviewed-by: Daniel Cheng \<dcheng@chromium.org>
Reviewed-by: Bo Liu \<boliu@chromium.org>
Reviewed-by: David Tseng \<dtseng@chromium.org>
Reviewed-by: Theresa Sullivan \<twellington@chromium.org>
Commit-Queue: Mason Freed \<masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1477967}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 34 tests ## Status Summary ### Firefox `OK` : 30 `PASS` : 4525 `FAIL` : 1884 `ERROR` : 2 `NOTRUN`: 1 ### Chrome `OK` : 31 `PASS` : 6914 `FAIL` : 217 `ERROR` : 1 `NOTRUN`: 1 ### Safari `OK` : 30 `PASS` : 4555 `FAIL` : 1901 `ERROR` : 2 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=17537eae2ab0c29326bbf6f5bb9965abbd5b8138) [GitHub PR Head](https://wpt.fyi/results/?sha=4094a5b254ca8d8759450c98c98047fa065023d9&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=4094a5b254ca8d8759450c98c98047fa065023d9&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 34 tests ## Status Summary ### Firefox `OK` : 30 `PASS` : 4525 `FAIL` : 1884 `ERROR` : 2 `NOTRUN`: 1 ### Chrome `OK` : 31 `PASS` : 6914 `FAIL` : 217 `ERROR` : 1 `NOTRUN`: 1 ### Safari `OK` : 30 `PASS` : 4555 `FAIL` : 1901 `ERROR` : 2 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=17537eae2ab0c29326bbf6f5bb9965abbd5b8138) [GitHub PR Head](https://wpt.fyi/results/?sha=4094a5b254ca8d8759450c98c98047fa065023d9&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=4094a5b254ca8d8759450c98c98047fa065023d9&label=pr_base) ## Details (See attachment for full changes)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: