1973834 - The Compose previews in Bookmarks are broken

Status: RESOLVED FIXED

(Firefox for Android :: Bookmarks, defect)

Description

[Noah Bond [:007]]

The Compose previews in BookmarksScreen are broken because of invoking the components singleton. It's used to obtain the AppStore, when it can just be a parameter on the BookmarksScreen API instead.

Components makes a call expecting an application context and all of the FenixApplication singleton dependencies to be initialized, which is broken on Compose previews, since the AppContext is never initialized in that scenario.

https://searchfox.org/mozilla-central/source/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/library/bookmarks/ui/BookmarksScreen.kt#114

We can either inline the AppStore dependency with the components call as the default value in the API and provide an empty AppStore in the previews, or make it a mandatory parameter of the API and provide the real AppStore at the BookmarksScreen callsite.

Comment 1

[Matt Tighe [:matt-tighe]]

:mavduevskiy, any chance you could take this?

Comment 2

[Mike a [:mavduevskiy]]

ooopsy

sure

Comment 3

[Mike a [:mavduevskiy]]

Attachment: Bug 1973834 - Fix bookmarks previews

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fd5aab6d09c4
https://hg.mozilla.org/integration/autoland/rev/900296eaceb9
Fix bookmarks previews r=android-reviewers,007

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/900296eaceb9