Closed Bug 1973870 Opened 10 months ago Closed 10 months ago

[wpt-sync] Sync PR 53374 - Fix I444P10 VideoFrame construction and extend test coverage

Categories

(Core :: Audio/Video: Web Codecs, task, P4)

task

Tracking

()

RESOLVED FIXED
142 Branch
Tracking Status
firefox142 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 53374 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53374
Details from upstream follow.

Dale Curtis <dalecurtis@chromium.org> wrote:

Fix I444P10 VideoFrame construction and extend test coverage

A copy/paste error mapped I444 to I422. This was uncaught since the
VideoFrame tests didn't check the returned format. Per the current
spec text, format shifting isn't allowed, so the format must match.

R=eugene

Fixed: 425901172
Change-Id: I45e378fe176c541018933b00dbac832e9ca2ee90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6669718
Reviewed-by: Eugene Zemtsov \<eugene@chromium.org>
Auto-Submit: Dale Curtis \<dalecurtis@chromium.org>
Commit-Queue: Eugene Zemtsov \<eugene@chromium.org>
Commit-Queue: Dale Curtis \<dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1478230}

Component: web-platform-tests → Audio/Video: Web Codecs
Product: Testing → Core

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 2 tests and 50 subtests

Status Summary

Firefox

OK : 2
PASS: 68
FAIL: 32

Chrome

OK : 2
PASS: 92
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /webcodecs/videoFrame-construction.any.html [wpt.fyi]
    • Test we can construct a I420P10 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I420P12 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I420AP10 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I420AP12 VideoFrame: FAIL (Chrome: FAIL)
    • Test we can construct a I422 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I422P10 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I422P12 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I422A VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I422AP10 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I422AP12 VideoFrame: FAIL (Chrome: FAIL)
    • Test we can construct a I444 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I444P10 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I444P12 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I444A VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I444AP10 VideoFrame: FAIL (Chrome: FAIL)
    • Test we can construct a I444AP12 VideoFrame: FAIL (Chrome: FAIL)
  • /webcodecs/videoFrame-construction.any.worker.html [wpt.fyi]
    • Test we can construct a I420P10 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I420P12 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I420AP10 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I420AP12 VideoFrame: FAIL (Chrome: FAIL)
    • Test we can construct a I422 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I422P10 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I422P12 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I422A VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I422AP10 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I422AP12 VideoFrame: FAIL (Chrome: FAIL)
    • Test we can construct a I444 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I444P10 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I444P12 VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I444A VideoFrame: FAIL (Chrome: PASS)
    • Test we can construct a I444AP10 VideoFrame: FAIL (Chrome: FAIL)
    • Test we can construct a I444AP12 VideoFrame: FAIL (Chrome: FAIL)
Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/78e916a18de6 https://hg.mozilla.org/integration/autoland/rev/846ecff0b37d [wpt PR 53374] - Fix I444P10 VideoFrame construction and extend test coverage, a=testonly
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
You need to log in before you can comment on or make changes to this bug.