1974057 - [wpt-sync] Sync PR 53392 - [SVG] Fixing nullptr exception during SVG style and layout recalculation

Status: RESOLVED FIXED

(Core :: SVG, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53392 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53392
Details from upstream follow.

Divyansh Mangal <[e-mail]> wrote:

[SVG] Fixing nullptr exception during SVG style and layout recalculation

CSS properties like {position:absolute} are not applied for
inner svg elements as inner svg elements don't follow CSS box model.
Below piece of code in StyleAdjuster::AdjustStyleForSvgElement
to used to handle this for inner svg elements

bool is_svg_root = element.IsOutermostSVGSVGElement();
if (!is_svg_root) {
builder.SetPosition(ComputedStyleInitialValues::InitialPosition());
}

However, if the style calculation is forced and CSS styles like
{position:absolute} are applied to svg elements along with
\<use> a nullptr exception is observed. (see the new test added in
this CL). This exception become more pronounced due to our change
in CL:6623901 which made it possible to replicate the crash.

In this CL, we remedy this problem by updating the above condition
based on the element that is actually being styled.

Bug: 425405650
Change-Id: Idf0b6e162d7017660ae46580a8154c521526922a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6653468
Reviewed-by: Fredrik Söderquist \<[e-mail]>
Commit-Queue: Divyansh Mangal \<[e-mail]>
Reviewed-by: Kurt Catti-Schmidt \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1478629}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=744b0bf731adae15ba0d9a01a4c12deb276eb513

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS : 1

Chrome

CRASH: 1

Safari

PASS : 1

Links

GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/47d3253ac4b0
https://hg.mozilla.org/integration/autoland/rev/729716b05a7b
[wpt PR 53392] - [SVG] Fixing nullptr exception during SVG style and layout recalculation, a=testonly

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/729716b05a7b