1974170 - Firefox rendering gets stuck after enabling system titlebar

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Gregory Pappas [:gregp]]

Attachment: stuck.webm

Steps to reproduce:

1. Right click the toolbar
2. Click "Customize toolbar..."
3. Enable the system titlebar by clicking "Title Bar"
4. Try to exit customize mode by selecting another tab or clicking "Done"

Actual results:
The title of the window changes, but Customize mode does not go away

Expected results:
Customize mode goes away

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1972291

:stransky, since you are the author of the regressor, bug 1972291, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

That's very interesting indeed.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Okay, I think we can just remove the assert and keep the frame callback as is as we use it for vsync only anyway.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1974170 [Wayland] Allow to rewrite wl_frame_callback handler r?emilio

Comment 5

[David Lawrence [:dkl]]

The content of attachment 9496945 [details] has been deleted for the following reason:

Requested by author

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/31a94bf8cedc
https://hg.mozilla.org/integration/autoland/rev/25e4aa14586a
[Wayland] Allow to rewrite wl_frame_callback handler r=emilio

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/25e4aa14586a