1974184 - Enable AES support for encrypting logins with the SDR and migrate all existing logins

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement)

Description

[Malte Jürgens [:maltejur]]

Now that AES-CBC support has been implemented behind a pref in Bug 198090, we should enable it by default and also handle migration of existing entries in logins.json.

Comment 1

[Malte Jürgens [:maltejur]]

Attachment: Bug 1974184 - Switch default SDR mechanism to AES r?simonf

Comment 2

[Malte Jürgens [:maltejur]]

Attachment: Bug 1974184 - Add migration to reencrypt all logins with AES r?simonf!,#credential-management-reviewers!,#firefox-desktop-core-reviewers!

Comment 3

[Simon Friedberger [:simonf]]

Just to be clear, you want to switch the default mechanism but not trigger a migration?

Comment 4

[Malte Jürgens [:maltejur]]

No, we want the migration to happen at the same time. I should have been more specific about that in the summary.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4ce194cc248e
https://hg.mozilla.org/integration/autoland/rev/97f68ff0fbad
Switch default SDR mechanism to AES r=joschmidt
https://github.com/mozilla-firefox/firefox/commit/a3c34ac6f4cc
https://hg.mozilla.org/integration/autoland/rev/85db0e86de33
Add migration to reencrypt all logins with AES r=credential-management-reviewers,firefox-desktop-core-reviewers ,joschmidt,mossop

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/97f68ff0fbad
https://hg.mozilla.org/mozilla-central/rev/85db0e86de33

Comment 7

[Donal Meehan [:dmeehan]]

:maltejur, could you consider nominating this for a release note? (Process info)

Comment 8

[Malte Jürgens [:maltejur]]

Release Note Request (optional, but appreciated)

Why is this notable:
Logins on desktop are now encrypted with a more modern encryption scheme, which increases security against attackers with disk access.

Affects Firefox for Android:
No

Suggested wording:
Logins in Firefox's built-in password manager are now encrypted using a more modern encryption scheme, switching from 3DES-CBC to AES-256-CBC. This change only affects the local encryption of logins on the disk; logins synced through Firefox Sync are end-to-end encrypted independently and have already been using a strong encryption scheme (AES-256-GCM) previously.

Links (documentation, blog post, etc):
n/a

Comment 9

[Malte Jürgens [:maltejur]]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 10

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx144 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx144 release notes.

Comment 11

[Donal Meehan [:dmeehan]]

Added to the Fx144 release notes