1974195 - [wpt-sync] Sync PR 53413 - Revert "Reland "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries""

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 53413 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/53413
Details from upstream follow.

Rune Lillesveen <[e-mail]> wrote:

Revert "Reland "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries""

This reverts commit a52f42ebb3ad75a62c2fe0f4a667807fb060cb30.

Reason for revert: Blocks revert https://chromium-review.googlesource.com/c/chromium/src/+/6678871

Original change's description:

Reland "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries"

This reverts commit bccaa635d365e6d91365a89c44481ab757aaa49b.

Reason for revert: I think I fixed the flakiness. :-)

Original change's description:

Revert "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries"

This reverts commit ae18e2a905e16727ae7c4e55988095c085cd09aa.

Reason for revert: Flaky on Linux bots due to race condition between rAF and presentation time callbacks. https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Aheadless_shell_wpt%2Fexternal%2Fwpt%2Fsoft-navigation-heuristics%2Flcp%2Ftentative%2Fraf-loop.html

Original change's description:

[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries

This tests that a click handler invocation which leads to the detection
of a soft navigation may defer some work with requestAnimationFrame, and
that work can generate additional soft LCP performance entries.

Change-Id: Ic432a8fed21a2836c122e6c1d7ba38150c901753
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6651298
Commit-Queue: Johannes Henkel \<[e-mail]>
Reviewed-by: Annie Sullivan \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1475225}

Change-Id: I866e47960f614817a26d14476098dbfe44021ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6657418
Bot-Commit: Rubber Stamper \<[e-mail]>
Reviewed-by: Michal Mocny \<[e-mail]>
Commit-Queue: Scott Haseley \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1476288}

Change-Id: Ic4615afa1b68461e5fad846304d49c44dfd2026c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6658297
Reviewed-by: Scott Haseley \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Johannes Henkel \<[e-mail]>
Reviewed-by: Michal Mocny \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1477725}

Change-Id: I84e3a14f05e23d7cae8f3f8ce931aba3ef8b06b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6678392
Commit-Queue: Rubber Stamper \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Auto-Submit: Rune Lillesveen \<[e-mail]>
Commit-Queue: Rune Lillesveen \<[e-mail]>
Owners-Override: Rune Lillesveen \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1479005}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 53413 applied with additional changes from upstream: f6a6f9b58259800fb76911912ac0692df5db264e, 7f8508e279c3a4cc97ef81b73643246a6b9f9717

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=12f306953013542b98c67c14b59754bf98ec6aa5

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1828e565c0ac
https://hg.mozilla.org/integration/autoland/rev/cea5278c038b
[wpt PR 53413] - Revert "Reland "[soft navs] WPT soft LCP test: requestAnimationFrame may generate additional LCP entries"", a=testonly

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/cea5278c038b