1974269 - The Pinned icon is not displayed on the selected state when opening the Shortcut menu with Space or Enter keys

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Rares Doghi, Desktop QA]

Attachment: 2025-06-26_14h57_19.png

Found in

• Nightly 142.0a1 (2025-06-26)

Affected versions

• Nightly 142.0a1 (2025-06-26)
• Beta 141.0b2

Affected platforms

• all

Steps to reproduce

1. Open the New Tab Page and pin a few shortcuts.
2. Reach Any Shortcut from the new tab page using keyboard navigation.
3. Reach the Shortcut menu and open it using the Space or Enter keys.

Expected result

• The pinned icon should be displayed for that selected state since the shortcut is pinned.

Actual result

• There is no indication that the shortcut is pinned if the user reachs the shortcut with keyboard navigation.
  If the user opens the shortcut Menu using keyboard navigation the pin icon is not displayed for that selected state.
  Only indication of the shortcut being pinned is the "Unpin" option.

Please note that in older builds before this feature the pinned icon was always displayed on the Top site.

Regression range
Not Applicable

Comment 1

[Amy Churchwell [:amy]]

Attachment: Bug 1974269 – topsites pinned icon is not displayed on focus. r=#home-newtab-reviewers

Comment 2

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:thecount, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/70c73d50f502
https://hg.mozilla.org/integration/autoland/rev/85d0f226d532
– topsites pinned icon is not displayed on focus. r=home-newtab-reviewers,reemhamz

Comment 4

[Amy Churchwell [:amy]]

Attachment: Bug 1974269 – topsites pinned icon is not displayed on focus. r=#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D256889

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Accessibility users can not see pinned icon when navigating topsites with keyboard.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps to test are in original bugzilla bug
• Risk associated with taking this patch: Low
• Explanation of risk level: Styles only patch
• String changes made/needed: N/A
• Is Android affected?: no

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/85d0f226d532

Comment 7

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 143.0a1 (2025-07-23)

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9a0f1c1ee4c1
https://hg.mozilla.org/releases/mozilla-beta/rev/e099a0beda31

Comment 9

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 142.0b3

Comment 10

[Scott [:thecount] Downe]

Attachment: Bug 1974269 – topsites pinned icon is not displayed on focus. r=#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D256889

Comment 11

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined: User impact to a11y
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Steps to test in bugzilla
• Risk associated with taking this patch: Low
• Explanation of risk level: It's some css for opacity on hover
• String changes made/needed: None
• Is Android affected?: no

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/0815172114a0
https://hg.mozilla.org/releases/mozilla-release/rev/cd119d515714

Comment 13

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Release 141.0.1

Comment 14

[Pascal Chevrel (relman team) -> :pascalc]

Downgrading to S3 as it fits more our user impact definition (https://wiki.mozilla.org/BMO/UserGuide/BugFields#bug_severity) and we also set it as access-S3