1974328 - Send ASRouter whether a newtab_message is shown in a selected tab

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task)

Comment 1

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1974328 - Check if newtab_message is displayed in selected browser r=#home-newtab-reviewers,#omc-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fde2cce46ed1
https://hg.mozilla.org/integration/autoland/rev/4498cc0bdcdf
Check if newtab_message is displayed in selected browser r=home-newtab-reviewers,omc-reviewers,aminomancer,maxx

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f21d7e2a8014
https://hg.mozilla.org/integration/autoland/rev/cafcdfba851c
Revert "Bug 1974328 - Check if newtab_message is displayed in selected browser r=home-newtab-reviewers,omc-reviewers,aminomancer,maxx" for causing newtab failures.

Comment 4

[Serban Stanca [:SerbanS]]

Reverted this because it was causing newtab failures.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | karma /builds/worker/checkouts/gecko/browser/extensions/newtab | activity-stream:ActionTypes should be in alpha order: expected 'ABOUT_SPONSORED_TOP_SITES, ADDONS_INFO_REQUEST, ADDONS_INFO_RESPONSE, ADS_FEED_UPDATE, ADS_INIT, ADS_RESET, ADS_UPDATE_SPOCS, ADS_UPDATE_TILES, BLOCK_SECTION, BLOCK_URL, BOOKMARK_URL, CARD_SECTION_IMPRESSION, CLEAR_PREF, COPY_DOWNLOAD_LINK, DELETE_BOOKMARK_BY_ID, DELETE_HISTORY_URL, DIALOG_CANCEL, DIALOG_CLOSE

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9965b701a0e2
https://hg.mozilla.org/integration/autoland/rev/40a9253f712d
Check if newtab_message is displayed in selected browser r=home-newtab-reviewers,omc-reviewers,aminomancer,maxx

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8faab923009a
https://hg.mozilla.org/integration/autoland/rev/d5372c77aec1
Revert "Bug 1974328 - Check if newtab_message is displayed in selected browser r=home-newtab-reviewers,omc-reviewers,aminomancer,maxx" for causing newtab failures

Comment 7

[pstanciu]

Backed out for causing newtab failures

• https://hg.mozilla.org/integration/autoland/rev/d5372c77aec1538797a1546d3cf346502d391605
• Push with failures
• Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d402289b74fc
https://hg.mozilla.org/integration/autoland/rev/377fd9152124
Check if newtab_message is displayed in selected browser r=home-newtab-reviewers,omc-reviewers,aminomancer,maxx

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/377fd9152124

Comment 10

[Nathan Barrett [:nbarrett]]

Attachment: Bug 1974328 - Check if newtab_message is displayed in selected browser r=#home-newtab-reviewers,#omc-reviewers

Original Revision: https://phabricator.services.mozilla.com/D255535

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: Message collision with newtab_message types could occur
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Steps in https://phabricator.services.mozilla.com/D255535
• Risk associated with taking this patch: Low
• Explanation of risk level: Does not change existing behavior and tests ahve been updated
• String changes made/needed: no
• Is Android affected?: no

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9499568 [details]
Bug 1974328 - Check if newtab_message is displayed in selected browser r=#home-newtab-reviewers,#omc-reviewers

Too late to take in our last beta and not a release blocker.

Comment 13

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this task using the latest Firefox Nightly 142.0a1 (Build ID: 20250710161616) build on Windows 10 x64, macOS 15.5, and Ubuntu 24.04.1.

• After following the testing steps from the Test Plan, I can confirm that the tab group message doesn't appear when left-clicking the tab group name.