1974382 - Anchor resolution visits siblings in incorrect order

Status: RESOLVED FIXED

(Core :: Layout: Positioned, defect)

Description

[Jari Jalkanen [:jari]]

Web platform test case [.target 1] is the only one that fails from the file css/css-anchor-position/anchor-position-003.html. In this test case, there are multiple valid anchor divs side by side on the same level in the DOM tree. The last one of them is expected to get chosen, corresponding to the reverse tree order, while in reality the first one of them gets chosen. The outcome of this test is not expected to depend on features that are not yet implemented at this time.

Comment 1

[Jari Jalkanen [:jari]]

Attachment: Bug 1974382: Avoid short-circuit evaluation on frame ancestor lookup. r=#anchor-positioning-reviewers

Comment 2

[Jari Jalkanen [:jari]]

Attachment: Bug 1974382: Avoid mixing anchors in different child lists. r=#anchor-positioning-reviewers

Anchors with identical names are organized in tree order.
During restyling, the tree undergoes restructuring and the ordering of the frames may go wrong.
With this patch, the adjustments during restyling are recorded and applied only after the tree is ready.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1924195

Comment 4

[Jari Jalkanen [:jari]]

Attachment: Stack trace about tree order comparison between frames in different child lists

To document the issue about frames belonging to different child lists when content has been added and we are performing a reflow, and this leading to CompareTreePosition not being able to decide the correct tree order which is detected by a debug assert, a stack trace is provided above.

Comment 5

[Jari Jalkanen [:jari]]

Here is a pernosco session for this same issue

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61e3989223b7
https://hg.mozilla.org/integration/autoland/rev/e72494023a87
Avoid short-circuit evaluation on frame ancestor lookup. r=layout-anchor-positioning-reviewers,dshin
https://github.com/mozilla-firefox/firefox/commit/05b31c496d13
https://hg.mozilla.org/integration/autoland/rev/554ab507a753
Avoid mixing anchors in different child lists. r=layout-anchor-positioning-reviewers,dshin

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f7b41339cca5
https://hg.mozilla.org/integration/autoland/rev/4d1d20e45202
Revert "Bug 1974382: Avoid mixing anchors in different child lists. r=layout-anchor-positioning-reviewers,dshin" for causing failures at SelectionActionDelegateTest.

Comment 8

[Atila Butkovits]

Backed out SelectionActionDelegateTest.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/4d1d20e45202f22b48f937639f255df6c93e6434

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=554ab507a753bd1b03af8d73025b1d24158fb01f&selectedTaskRun=IKtLoAmJRcGXXo_oD3LAMg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=517786815&repo=autoland&lineNumber=14292

Comment 9

[Jari Jalkanen [:jari]]

Attachment: WIP: Bug 1974382: Ignore frame if inserted again among anchors.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/46c9062e4f5a
https://hg.mozilla.org/integration/autoland/rev/a6611a86996a
Avoid short-circuit evaluation on frame ancestor lookup. r=layout-anchor-positioning-reviewers,dshin
https://github.com/mozilla-firefox/firefox/commit/f9b77c969807
https://hg.mozilla.org/integration/autoland/rev/9ec68e348798
Avoid mixing anchors in different child lists. r=layout-anchor-positioning-reviewers,dshin,emilio

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing leak failures

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/038e49c082b553224477272207980eb0c6c9c522

Push with failures

Failure log linux

Failure log osx

Failure log win

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a6611a86996a
https://hg.mozilla.org/mozilla-central/rev/9ec68e348798

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jari, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox142 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Jonathan Watt [:jwatt]]

This got backed out, right?

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2041e6327e6f
https://hg.mozilla.org/integration/autoland/rev/b9c00262fc8d
Avoid short-circuit evaluation on frame ancestor lookup. r=layout-anchor-positioning-reviewers,dshin
https://github.com/mozilla-firefox/firefox/commit/dd03850738f7
https://hg.mozilla.org/integration/autoland/rev/c6b20aeb5d45
Avoid mixing anchors in different child lists. r=layout-anchor-positioning-reviewers,dshin,emilio

Comment 16

[[e-mail]]

Backed out for causing wpt failures

- Backout link
- Push with failures
- Also see this
- Failure log

Failure line:TEST-UNEXPECTED-PASS | /css/css-anchor-position/anchor-position-circular.html | Testing http://web-platform.test:8000/css/css-anchor-position/anchor-position-circular.html == http://web-platform.test:8000/css/css-anchor-position/reference/anchor-position-circular-ref.html

Comment 17

[pstanciu]

backout was merged to central

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1e5321620abb
https://hg.mozilla.org/integration/autoland/rev/50a0d3521b8b
Avoid short-circuit evaluation on frame ancestor lookup. r=layout-anchor-positioning-reviewers,dshin
https://github.com/mozilla-firefox/firefox/commit/7ef20f5498d6
https://hg.mozilla.org/integration/autoland/rev/fdd8ff04e351
Avoid mixing anchors in different child lists. r=layout-anchor-positioning-reviewers,dshin,emilio

Comment 19

[amarc]

Backed out for causing for causing wr failures @ anchor-position-circular.html

• Backout link
• Push with failures
• Failure Log
• Failure log -> wpt failure: https://treeherder.mozilla.org/?repo=autoland&duplicate_jobs=visible&group_state=expanded&selectedTaskRun=SmmdHLNrTjWpRhyjdNbtWQ.0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&fromchange=82776e4e0e5070d7bf2c1c894e57207fe8c43038&searchStr=Linux%2C24.04%2Copt%2CWeb%2Cplatform%2Ctests%2Ctest-linux2404-64%2Fopt-web-platform-tests%2Cwpt10

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b54233122e72
https://hg.mozilla.org/integration/autoland/rev/6e2836763b10
Avoid short-circuit evaluation on frame ancestor lookup. r=layout-anchor-positioning-reviewers,dshin
https://github.com/mozilla-firefox/firefox/commit/1be7a65f05b8
https://hg.mozilla.org/integration/autoland/rev/99af88954512
Avoid mixing anchors in different child lists. r=layout-anchor-positioning-reviewers,dshin,emilio

Comment 21

[Cristina Horotan [:chorotan]]

Backed out for causing wpt failures on anchor-name-003.html

Backout link

Push with failures

Failure log

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a857eb71dd6f
https://hg.mozilla.org/integration/autoland/rev/0825b0eeb519
Avoid short-circuit evaluation on frame ancestor lookup. r=layout-anchor-positioning-reviewers,dshin
https://github.com/mozilla-firefox/firefox/commit/d64e49349047
https://hg.mozilla.org/integration/autoland/rev/2845a1497070
Avoid mixing anchors in different child lists. r=layout-anchor-positioning-reviewers,dshin,emilio

Comment 23

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0825b0eeb519
https://hg.mozilla.org/mozilla-central/rev/2845a1497070