1974383 - Implement `headingoffset` attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Keith Cirkel [:keithamus]]

This is a tracking issue for implementing the proposed headingoffset attribute as discussed in https://github.com/whatwg/html/issues/5033. There is a draft spec: https://github.com/whatwg/html/pull/11086

Comment 1

[James Teh [:Jamie]]

Just a heads up that this will require accessibility engine changes at multiple layers. The most obvious place is here. However, because this method is in the Accessible base class and must thus work for both local and remote Accessibles, some mechanism will need to be added to get the offset, and that will need to be pushed from content to parent and included in the RemoteAccessible cache.

Comment 2

[Keith Cirkel [:keithamus]]

(In reply to James Teh [:Jamie] from comment #1)

Just a heads up that this will require accessibility engine changes at multiple layers. The most obvious place is here. However, because this method is in the Accessible base class and must thus work for both local and remote Accessibles, some mechanism will need to be added to get the offset, and that will need to be pushed from content to parent and included in the RemoteAccessible cache.

Thanks for this! For RemoteAccessible I was looking to put the level as a CacheKey of mCachedFields, but I am happy to take suggestions for alternative/better ways to handle this.

Comment 3

[Keith Cirkel [:keithamus]]

Attachment: Bug 1974383 - Implement headingoffset r?#dom-core,#accessibility-platform-reviewers,#webidl,#firefox-style-system-reviewers

Comment 4

[Serban Stanca [:SerbanS]]

Reverted this because it was causing build bustages in RemoteAccessible.cpp.

• Revert link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/accessible/ipc/RemoteAccessible.cpp:X:7: error: use of undeclared identifier 'RequestDomainsIfInactive'

Comment 5

[Keith Cirkel [:keithamus]]

Ah looks like https://phabricator.services.mozilla.com/D299959 (https://bugzilla.mozilla.org/show_bug.cgi?id=2021820) slipped by. Rebase needed.

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60054 for changes under testing/web-platform/tests

Comment 7

[Serban Stanca [:SerbanS]]

Reverted this because it was causing non-unified build bustages in nsINode.h.

• Revert link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/base/nsINode.h:1231:33: error: inline function 'nsINode::GetFlattenedTreeParentElement' is not defined [-Werror,-Wundefined-inline]

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/01c40e5a586f
https://hg.mozilla.org/integration/autoland/rev/b3677357740c
Implement headingoffset r=dom-core,accessibility-platform-reviewers,webidl,firefox-style-system-reviewers,smaug,emilio,Jamie,saschanaz

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1b706d0c7c6b
https://hg.mozilla.org/integration/autoland/rev/135a79276dbe
Implement headingoffset r=dom-core,accessibility-platform-reviewers,webidl,firefox-style-system-reviewers,smaug,emilio,Jamie,saschanaz

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4517bc15ec3d
https://hg.mozilla.org/integration/autoland/rev/a89bdaf6bba6
Implement headingoffset r=dom-core,accessibility-platform-reviewers,webidl,firefox-style-system-reviewers,smaug,emilio,Jamie,saschanaz

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/a89bdaf6bba6

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5c4e7f51581e
adjust mail/base/test/browser/static/browser_parsable_css.js for bug 1974383. rs=bustage-fix

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot