1974684 - moz-phab submit fails with "ambiguous argument 'c4cc52826abd53e1121e4234d719cfd89ce58093^...': unknown revision or path not in the working tree" (git setup)

Status: RESOLVED WORKSFORME

(Conduit :: moz-phab, defect)

Description

[Mark Banner (:standard8)]

moz-phab version (from moz-phab version): 1.11.0

I've got a patch that's based on the tip of firefox-main, and moz-phab submit is failing with:

% moz-phab submit        
fatal: ambiguous argument 'c4cc52826abd53e1121e4234d719cfd89ce58093^...': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
CommandError: command 'git' failed to complete successfully
Run moz-phab again with '--trace' to show debugging output

If I revert to version 1.10.0, then the submit works fine.

% moz-phab submit                                       
Determining the commit range using upstream "main"
Submitting 1 commit for review
(New) 53b12f01d5ce Bug 1974683 - Fix TV failures in browser_searchbar_keyboard_navigation.js relating to not waiting for the search one-offs to rebuiled. r?mbeier!

My branch setup:

% git branch -vv
  autoland                                 ee976d459e85 [origin/autoland: behind 3514] Bug 1970605 - Add JSON storage checksum function to determine rolling migration checkpoint r=dimi
  beta                                     806c3d739b3a [origin/beta: behind 8936] Bug 1962301 - [devtools] Escape windows special characters for strings  a=RyanVM
  esr128                                   2a449e8180be [origin/esr128: behind 53] Bug 1964060: fallback to github when tags can't be found on hg.m.o in update verify config creator r=releng-reviewers,ahal a=RyanVM
  esr140                                   8dade65deaae [origin/esr140: behind 5457] No Bug - Bumping Mobile l10n changesets r=release a=l10n-bump
* inter-fixes                              53b12f01d5ce Bug 1974683 - Fix TV failures in browser_searchbar_keyboard_navigation.js relating to not waiting for the search one-offs to rebuiled. r?mbeier
  main                                     f896478cc65a [origin/main] Revert "Bug 1967780: Generate some additional noise for LCP time when sent via Domain ping.  r=bas" as requested by Bas for causing Bug 1974659.

My remotes:

% git remote -v
origin	[e-mail]:mozilla-firefox/firefox.git (fetch)
origin	[e-mail]:mozilla-firefox/firefox.git (push)

The log of the top 2 commits:

% git log -2
commit 53b12f01d5ce4dc1edb24ec213e1f6a78ace2917 (HEAD -> inter-fixes)
Author: Mark Banner <[e-mail]>
Date:   Sat Jun 28 12:19:55 2025 +0100

    Bug 1974683 - Fix TV failures in browser_searchbar_keyboard_navigation.js relating to not waiting for the search one-offs to rebuiled. r?mbeier

commit f896478cc65a33fd2008f1bc003124316410fd14 (origin/main, origin/HEAD, main)
Author: Cosmin Sabou <[e-mail]>
Date:   Mon Jun 30 00:18:07 2025 +0300

    Revert "Bug 1967780: Generate some additional noise for LCP time when sent via Domain ping.  r=bas" as requested by Bas for causing Bug 1974659.
    
    This reverts commit fcf8ae5b8798f190f971bc62e13f1cefaa5b53c7.
    
    Revert "Bug 1967780: Add checks for public IP ranges, roots from the builtin list, and wildcard names. r=jesup,mt"
    
    This reverts commit a4b98f70c710c551f51ed930d1c0770ded47881d.
    
    Revert "Bug 1967780: Add new ETLD+1 pageload event and ping using ohttp. r=bas,data-stewards,mt"
    
    This reverts commit dbc47a0021a148a8c659bf9672869be9e0005921.
    
    Revert "Bug 1967780: Reduce frequency of existing pageload event and restructure existing data structures for the pageload event. r=bas"
    
    This reverts commit 8bd2ba9aa4c04c6a7dbd9a5cefb3be20e82312de.

Comment 1

[Mark Banner (:standard8)]

Apologies for the noise, I missed it previously, I was just looking at the trace log and noticed:

$ git -c i18n.logOutputEncoding=UTF-8 -c i18n.commitEncoding=UTF-8 rev-list HEAD --topo-order --boundary --not --remotes=main

I realised the main was possibly wrong as my remote is origin. In my .moz-phab-config file I had:

[git]
remote = main

I believe this was needed in the past to make it work with cinnabar (or maybe it wasn't, I'm not sure), however I've removed it and it now submits fine.