1974712 - TypeScript issue in UnitConverterSimple.sys.mjs - Argument of type 'number' is not assignable to parameter of type 'string'

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Mark Banner (:standard8)]

After landing of bug 1969249, there's now a TypeScript error shown when loading UnitConverterSimple.sys.mjs into VS Code or when running ./mach ts check browser/components/urlbar:

browser/components/urlbar/unitconverters/UnitConverterSimple.sys.mjs:197:7 - error TS2345: Argument of type 'number' is not assignable to parameter of type 'string'.

197       (inputNumber / group[inputUnit]) * group[outputUnit]
          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 1 error in browser/components/urlbar/unitconverters/UnitConverterSimple.sys.mjs:197

Yazan, please can you take a look.

Comment 1

[Yazan Al Macki [:yazan]]

Attachment: Bug 1974712 - Remove erroneous parseFloat call on number. r?standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/16377e7008a7
https://hg.mozilla.org/integration/autoland/rev/c02f1a2cc284
Remove erroneous parseFloat call on number. r=Standard8,urlbar-reviewers

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/c02f1a2cc284