1974787 - (appearance-base-select) [css-forms-1] Add support for `appearance: base-select` style value

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Keith Cirkel [:keithamus]]

The new appearance: base & appearance: base-select style values should be parsed, and allow <select> elements to be styled generically.

We should endeavour to implement base behind a flag specific to this, as we do not want generic web content to use appearance: base until the remainder of form controls have fully implemented their respective base styles.

Comment 2

[Daniel Holbert [:dholbert]]

Let's narrow this to be about just base-select, and spin off base to another bug. base-select is the only piece that's needed for bug 1944403,, I think.

(base-select is defined as behaving like base on <select> elements, but we very well may implement it before we implement appearance:base, and then only wire them up after we've started working on appearance:base)

Comment 4

[Tiaan Louw [:tlouw]]

Attachment: Bug 1974787 - Add support for appearance: base-select r=#layout

This adds the base-select value to the appearance CSS property. It
is part of the customizable <select> implementation and is behind a
pref: layout.css.appearance-base-select.enabled.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c6641dadc3f5
https://hg.mozilla.org/integration/autoland/rev/a1576349cd6e
Add support for appearance: base-select r=layout-reviewers,firefox-style-system-reviewers,emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/90533376f5d3
https://hg.mozilla.org/integration/autoland/rev/70345b092cac
Revert "Bug 1974787 - Add support for appearance: base-select r=layout-reviewers,firefox-style-system-reviewers,emilio" for causing failures at select-pseudo-open.html.

Comment 7

[Atila Butkovits]

Backed out for causing failures at select-pseudo-open.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/70345b092cac

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&duplicate_jobs=visible&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=a1576349cd6e1387ddc06647682a5e6b65d702f7&selectedTaskRun=R6ysfjWWQlCdn6-ADeXDfg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=548189513&repo=autoland&task=R6ysfjWWQlCdn6-ADeXDfg.0&lineNumber=4803

Comment 8

[Tiaan Louw [:tlouw]]

Failure seems to be on Android only, running another try run with linux and android to confirm.

https://treeherder.mozilla.org/jobs?repo=try&landoCommitID=179212

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/907c848bb07c
https://hg.mozilla.org/integration/autoland/rev/af5cceb67fe5
Add support for appearance: base-select r=layout-reviewers,firefox-style-system-reviewers,emilio

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/af5cceb67fe5

Comment 11

[Dave Letorey]

Related pull requests

• BCD PR
• FF Release PR