1974881 - Windows video hardware decoding is broken

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P1)

Description

[Alastor Wu [:alwu]]

My device is capable to perform HW decoding, but HW decoding fails to work on the latest Nightly. The about:support shows the message Blocklisted; failure code FEATURE_FAILURE_BROKEN_TEXTURE_SHARING.

Comment 1

[Alastor Wu [:alwu]]

Attachment: about:support

Comment 2

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1974881 - Fix hardware video detection with GPU process.

When the GPU process finishes initializing, it provides an update over
IPDL to the parent process about our D2D state, including texture
sharing. We need to fully reinitialize the hardware video decoding and
encoding features when this happens, not just disable them if the
features are broken, to allow for recovery.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0842a34ec236
https://hg.mozilla.org/integration/autoland/rev/de3a0dfa2fb9
Fix hardware video detection with GPU process. r=alwu

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/de3a0dfa2fb9

Comment 6

[Alex Finder]

(In reply to Pulsebot from comment #3)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0842a34ec236
https://hg.mozilla.org/integration/autoland/rev/de3a0dfa2fb9
Fix hardware video detection with GPU process. r=alwu

Perfherder has detected a browsertime performance change from push d7b23a92d73b417548ba88da8108c5476d55b6fd.

If you have any questions, please reach out to a performance sheriff. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
34%	tumblr loadtime	windows11-64-24h2-shippable	fission warm webrender	386.66 -> 254.21	Before/After
27%	tumblr ContentfulSpeedIndex	windows11-64-24h2-shippable	fission warm webrender	177.23 -> 129.19	Before/After
25%	tumblr SpeedIndex	windows11-64-24h2-shippable	fission warm webrender	163.05 -> 122.82	Before/After
21%	tumblr PerceptualSpeedIndex	windows11-64-24h2-shippable	fission warm webrender	131.32 -> 103.36	Before/After
21%	tumblr largestContentfulPaint	windows11-64-24h2-shippable	fission warm webrender	405.58 -> 321.09	Before/After
...	...	...	...	...	...
5%	tumblr PerceptualSpeedIndex	windows11-64-24h2-shippable	cold fission webrender	423.93 -> 401.65	Before/After

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a performance sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 45866

The following documentation link provides more information about this command.