1974946 - Compilation failure for riscv64 JIT: no member named 'pushFrameDescriptor' in 'js::jit::MacroAssembler' at jit/riscv64/SharedICHelpers-riscv64-inl.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Rong Bao [:csmantle]]

Revision https://phabricator.services.mozilla.com/D251070 unified various MacroAssembler::push* family of methods into a single MacroAssembler::push and updated related calls. However, one call to the former methods was left unchanged, causing this compliation failure.

Comment 1

[Rong Bao [:csmantle]]

Attachment: Related error log

Comment 2

[BugBot [:suhaib / :marco]]

:iain, since you are the author of the regressor, bug 1960433, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Rong Bao [:csmantle]]

Attachment: Bug 1974946 - [riscv64] Use MacroAssembler::push method in jit/riscv64/SharedICHelpers-riscv64-inl.h. r=jandem

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e75cc43d0b85
https://hg.mozilla.org/integration/autoland/rev/72fb748a65a0
[riscv64] Use MacroAssembler::push method in jit/riscv64/SharedICHelpers-riscv64-inl.h. r=jandem

Comment 5

[[e-mail]]

https://hg.mozilla.org/mozilla-central/rev/72fb748a65a0

Comment 6

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1960433

Comment 7

[Rong Bao [:csmantle]]

We may need to revert this bug as well together with bug 1960433.

Comment 8

[Jan de Mooij [:jandem]]

I've requested a backout.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ed3c90bc2938
https://hg.mozilla.org/integration/autoland/rev/7f609608e697
Revert "Bug 1974946 - [riscv64] Use MacroAssembler::push method in jit/riscv64/SharedICHelpers-riscv64-inl.h. r=jandem" as requested by Jandem.

Comment 10

[Cosmin Sabou [:CosminS]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/7f609608e697

Comment 11

[BugBot [:suhaib / :marco]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:csmantle, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 12

[Rong Bao [:csmantle]]

The bot's concerns don't seem valid -- I think this bug needs to be kept open as long as bug 1960433 is still in flight.

Comment 13

[Rong Bao [:csmantle]]

Iain, should we also reapply this patch to main?

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c1ad6bb98d96
https://hg.mozilla.org/integration/autoland/rev/34c89bdffc6a
[riscv64] Use MacroAssembler::push method in jit/riscv64/SharedICHelpers-riscv64-inl.h. r=jandem

Comment 15

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/34c89bdffc6a