1974950 - Do not throw if DOM attribute setter is called with no arguments

Status: RESOLVED FIXED

(Core :: DOM: Bindings (WebIDL), task)

Description

[Tooru Fujisawa [:arai]]

for https://github.com/whatwg/webidl/issues/1497

The spec requires the DOM attribute setter to throw if it's called with no arguments, but the behavior doesn't match across browsers,
and also throwing there doesn't match ECMAScript built-ins.

The possible fix is to modify the spec not to throw, but treat it as undefined value, and update implementation to follow it.

I have a patch, and will post it shortly

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1974950 - Part 1: Treat no arguments as undefined in DOM setters. r=smaug!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1974950 - Part 2: Add tests for DOM attribute setter with no arguments r=smaug!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:arai, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 4

[Kagami Rosylight [:saschanaz] (they/them)]

I see no blocker to land 👀

Comment 5

[Tooru Fujisawa [:arai]]

it's waiting for https://github.com/whatwg/webidl/pull/1498 to become ready to merge,
so that we can land the spec change and the WPT at the same time.

I'll check if/how Node is affected.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7c5d1853af53
https://hg.mozilla.org/integration/autoland/rev/bfdc0f72dbb4
Part 1: Treat no arguments as undefined in DOM setters. r=smaug,saschanaz
https://github.com/mozilla-firefox/firefox/commit/d2ae148cef90
https://hg.mozilla.org/integration/autoland/rev/d175cc1d3a07
Part 2: Add tests for DOM attribute setter with no arguments r=smaug,saschanaz

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/53894 for changes under testing/web-platform/tests

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bfdc0f72dbb4
https://hg.mozilla.org/mozilla-central/rev/d175cc1d3a07

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot