Closed
Bug 1974977
Opened 1 year ago
Closed 1 year ago
allow badging non-native menu items with "New"
Categories
(Toolkit :: Themes, enhancement)
Toolkit
Themes
Tracking
()
VERIFIED
FIXED
142 Branch
People
(Reporter: Mardak, Assigned: Mardak)
References
(Blocks 1 open bug)
Details
(Whiteboard: [genai])
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
like bug 1970651 for native macos menus and split the css change from bug 1971178
| Assignee | ||
Comment 1•1 year ago
|
||
Split menu styling from D253104.
Updated•1 year ago
|
Assignee: nobody → edilee
Status: NEW → ASSIGNED
| Assignee | ||
Updated•1 year ago
|
Whiteboard: [genai]
Updated•1 year ago
|
Updated•1 year ago
|
QA Contact: rdoghi
Pushed by elee@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/f6054c20b1e5
https://hg.mozilla.org/integration/autoland/rev/54b25c7a1866
allow badging non-native menu items with "New" r=emilio,desktop-theme-reviewers
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox142:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 142 Branch
Comment 4•1 year ago
|
||
This issue is verified as fixed on Windows and Linux in our latest Nightly 142.0a1 (2025-07-02) , Mac Os < 14 still has this issue, I cannot see the new badge on a MacOs 11.7
QA Whiteboard: [qa-ver-needed-c142/b141]
status-firefox140:
--- → disabled
status-firefox141:
--- → affected
status-firefox-esr140:
--- → disabled
| Assignee | ||
Comment 5•1 year ago
|
||
Split menu styling from D253104.
Original Revision: https://phabricator.services.mozilla.com/D255636
Updated•1 year ago
|
Attachment #9498458 -
Flags: approval-mozilla-beta?
Comment 6•1 year ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined: windows users don't see "New" on summarize page menu item available for macos
- Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: yes
- Steps to reproduce for manual QE testing: 1. enable feature with browser.ml.chat.page 2. open page context menu
- Risk associated with taking this patch: low
- Explanation of risk level: css addition for badge attribute that's currently only activated from page summarize experiment
- String changes made/needed: no
- Is Android affected?: no
Flags: qe-verify+
Updated•1 year ago
|
QA Whiteboard: [qa-ver-needed-c142/b141] → [qa-ver-needed-c142/b141][uplift]
Updated•1 year ago
|
Attachment #9498458 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•1 year ago
|
Comment 8•1 year ago
|
||
This issue is verified as fixed in our latest Beta 141.0b6.
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-ver-needed-c142/b141][uplift] → [qa-ver-done-c142/b141][uplift]
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•