1975002 - Custom avatar images are not properly decoded before being passed to nsITaskbarOverlayIconController.setOverlayIcon

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect, P2)

Description

[Niklas Baumgardner [:niklas]]

With the new custom avatar selector on windows, setting the overlay icon currently fails.
NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsITaskbarOverlayIconController.setOverlayIcon]
We should update SetOverlayIcon to allow a custom avatar image.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1975002: Ensure we fully decode images before trying to use them in the Dock or Taskbar. r=#profiles-reviewers!

Comment 2

[Dave Townsend [:mossop]]

The problem isn't with nsITaskbarOverlayIconController.setOverlayIcon, it's that we aren't decoding images before passing them. For vector images this isn't an issue but it is for raster images. Happily the same fix works for both.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/faa94134b35c
https://hg.mozilla.org/integration/autoland/rev/2ef57d67fd06
Ensure we fully decode images before trying to use them in the Dock or Taskbar. r=profiles-reviewers,niklas

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2ef57d67fd06