1975024 - Cleanup some cache code and locking to prepare for Compression Dictionaries

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement, P3)

Description

[Randell Jesup [:jesup] (needinfo me)]

Clean up the locking code for CacheStorageService; also add some comments about how we're keying, etc.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1975024: Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:jesup, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f275cacfa2bc
https://hg.mozilla.org/integration/autoland/rev/64ed83210fbc
Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing multiple bustages/failures

Backout link: https://hg.mozilla.org/integration/autoland/rev/837a3d407e1c473641116eb9e1a150237c764645

Push with failures

Failure log -> TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/netwerk/test/unit/test_dictionary_storage.js:595:9 | 'headerValue' is assigned a value but never used. (no-unused-vars)

Failure log -> ERROR - /builds/worker/checkouts/gecko/netwerk/streamconv/converters/nsHTTPCompressConv.cpp:358:23: error: format '%d' expects argument of type 'int', but argument 4 has type 'nsresult' [-Werror=format=]

Failure log -> ERROR - /builds/worker/workspace/obj-build/dist/include/mozilla/net/Dictionary.h:313:14: error: unused variable 'rv' [-Werror,-Wunused-variable]

Failure log -> TEST-UNEXPECTED-FAIL | netwerk/test/unit/test_trr.js | test_server_up - [test_server_up : 84] "undefined" == "Error: could not find id"

Failure log -> TEST-UNEXPECTED-FAIL | /service-workers/service-worker/worker-interception.https.html

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_copy_headers.js | Timed out while polling clipboard for requested data

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/64ed83210fbc

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/564fa928341c
https://hg.mozilla.org/integration/autoland/rev/40951666d740
Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw

Comment 7

[amarc]

Backed out for causing multiple failures

• Backout link
• Push with failures
• Failure Log
• Failure Log 2
• Failure Log 3

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/06538c79f3da
https://hg.mozilla.org/integration/autoland/rev/ece2c5fba662
Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a6c4d697d279
https://hg.mozilla.org/integration/autoland/rev/08d053aca43d
Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9c189563abd3
https://hg.mozilla.org/integration/autoland/rev/65dc3d6d029a
Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/65dc3d6d029a

Comment 12

[Atila Butkovits]

Backed out for causing failures /dictionary-compressed.tentative.https.html.

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/339cb96b8aea9a433abdfee35eca4472ecb7074e

Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=windows%2C11%2Cx86%2C24h2%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows11-32-24h2%2Fopt-web-platform-tests%2Cwpt12&revision=f63dea815067f6fefbac80cce46e1a0589f66a31&selectedTaskRun=OXPZFu52Tyq66R0qicmggw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=529651894&repo=autoland&task=OXPZFu52Tyq66R0qicmggw.0&lineNumber=10724

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c7325cad6fa2
https://hg.mozilla.org/integration/autoland/rev/e43cbf5e6686
Revert "Bug 1975024: Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw" for causing build bustages in CacheStorageService.cpp

Comment 14

[Atila Butkovits]

Backout merged: https://hg-edge.mozilla.org/mozilla-central/rev/339cb96b8aea9a433abdfee35eca4472ecb7074e

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5dd4896f18ff
https://hg.mozilla.org/integration/autoland/rev/d8a9a6f93bfb
Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8cc9073e81a6
https://hg.mozilla.org/integration/autoland/rev/9e22dd40d9e6
Cleanup Cache code and locks in prep for Compression Dictionaries #necko-reviewers r=necko-reviewers,kershaw

Comment 17

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/9e22dd40d9e6