1975140 - Reset scroll position before each test in test_click_scrolling.py

Status: RESOLVED FIXED

(Testing :: Marionette Client and Harness, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Right now we are not resetting the scroll position of the current tab under test in-between the individual sub tests in test_click_scrolling.py. This can lead to unexpected failures in following tests as seen on bug 1867054.

As I checked with the following try build calling window.scroll(0, 0) during setUp will fix it.
https://treeherder.mozilla.org/jobs?repo=try&revision=97697c1b0dbd65b2e321a1ed730d12ccfa07993e

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1975140 - [marionette] Reset scroll position before each test in test_click_scrolling.py.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6fab02b28adb
https://hg.mozilla.org/integration/autoland/rev/16276caadadd
[marionette] Reset scroll position before each test in test_click_scrolling.py. r=webdriver-reviewers,jdescottes

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/16276caadadd

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1975140 - [marionette] Reset scroll position before each test in test_click_scrolling.py.

Original Revision: https://phabricator.services.mozilla.com/D255754

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined: None, only affects unit tests for Marionette
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: None
• Risk associated with taking this patch: Very low
• Explanation of risk level: Only resets the window scroll position before each scroll test to ensure proper scrolling by using the initial 0,0 position
• String changes made/needed: None
• Is Android affected?: no

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/edd9373b56cd
https://hg.mozilla.org/releases/mozilla-beta/rev/f6784c125ca2